# symbol string_list_appendf() unused 4 messages from 2018-05-21 to 2018-05-22. Participants: Ramsay Jones, Junio C Hamano, Martin Ågren. Thread: https://gitlist.dev/t/48541 ## Ramsay Jones, 2018-05-21 23:56 Subject: symbol string_list_appendf() unused Message-ID: URL: https://gitlist.dev/e/d203f6ef-f684-cf6b-07b0-553b6b79e189%40ramsayjones.plus.com ``` Hi Martin, I strongly suspect that I haven't followed the discussion on the list closely enough, but your 'ma/unpack-trees-free-msgs' branch in 'pu', seems to define string_list_appendf() but then never call it. This is despite commit 40ebd6c7b0 ("string-list: provide `string_list_appendf()`", 2018-05-20) claiming that: 'The next commit will add a user'. ;-) Have I missed something? ATB, Ramsay Jones ``` ## Junio C Hamano, 2018-05-21 23:59 Subject: Re: symbol string_list_appendf() unused Message-ID: URL: https://gitlist.dev/e/xmqqvabgzhjr.fsf%40gitster-ct.c.googlers.com In-Reply-To: ``` Ramsay Jones writes: > I strongly suspect that I haven't followed the discussion on > the list closely enough, but your 'ma/unpack-trees-free-msgs' > branch in 'pu', seems to define string_list_appendf() but then > never call it. This is despite commit 40ebd6c7b0 ("string-list: > provide `string_list_appendf()`", 2018-05-20) claiming that: > 'The next commit will add a user'. ;-) > > Have I missed something? Yes, I pushed out a tentative "how about doing it this way" update that goes alongside his version, making some solutions (including the function you found) he had obsoleted, yet without removing them. That is what you saw on 'pu'. There is a reroll by Martin that ties all the loose ends. Thanks for paying great attention to the details. Always appreciated. ``` ## Ramsay Jones, 2018-05-22 00:08 Subject: Re: symbol string_list_appendf() unused Message-ID: <50d629b9-bf89-77af-a1ee-6175745c5e42@ramsayjones.plus.com> URL: https://gitlist.dev/e/50d629b9-bf89-77af-a1ee-6175745c5e42%40ramsayjones.plus.com In-Reply-To: ``` On 22/05/18 00:59, Junio C Hamano wrote: > Ramsay Jones writes: > >> I strongly suspect that I haven't followed the discussion on >> the list closely enough, but your 'ma/unpack-trees-free-msgs' >> branch in 'pu', seems to define string_list_appendf() but then >> never call it. This is despite commit 40ebd6c7b0 ("string-list: >> provide `string_list_appendf()`", 2018-05-20) claiming that: >> 'The next commit will add a user'. ;-) >> >> Have I missed something? > > Yes, I pushed out a tentative "how about doing it this way" update > that goes alongside his version, making some solutions (including > the function you found) he had obsoleted, yet without removing > them. That is what you saw on 'pu'. > > There is a reroll by Martin that ties all the loose ends. Ah, OK, sorry for the noise. Thanks! ATB, Ramsay Jones ``` ## Martin Ågren, 2018-05-22 10:55 Subject: Re: symbol string_list_appendf() unused Message-ID: URL: https://gitlist.dev/e/CAN0heSrTpWGqCRMfhhyGqCX7TcBUKXbJWJp0yDy0cLQdhhwdHQ%40mail.gmail.com In-Reply-To: <50d629b9-bf89-77af-a1ee-6175745c5e42@ramsayjones.plus.com> ``` Hi Ramsay On 22 May 2018 at 02:08, Ramsay Jones wrote: > On 22/05/18 00:59, Junio C Hamano wrote: >> There is a reroll by Martin that ties all the loose ends. > > Ah, OK, sorry for the noise. No worry. Thanks for pointing out the unused function to me. I appreciate it. Martin ```