threads / patch / 48138

patchbisect: use oid_to_hex() for converting object_id hashes to hex strings

Subject: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

## tl;dr

3 messages between Mar 25, 2018 and Mar 25, 2018. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

René Scharfe· Mar 25, 2018, 10:57 UTC · lore

Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
object to object_id).

 bisect.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Show changes to bisect.c +2 −2

diff --git a/bisect.c b/bisect.c
index f6d05bd66f..319d60edad 100644
--- a/bisect.c
+++ b/bisect.c
@@ -144,10 +144,10 @@ static void show_list(const char *debug, int counted, int nr,
 			fprintf(stderr, "%3d", weight(p));
 		else
 			fprintf(stderr, "---");
-		fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.oid.hash));
+		fprintf(stderr, " %.*s", 8, oid_to_hex(&commit->object.oid));
 		for (pp = commit->parents; pp; pp = pp->next)
 			fprintf(stderr, " %.*s", 8,
-				sha1_to_hex(pp->item->object.oid.hash));
+				oid_to_hex(&pp->item->object.oid));
 
 		subject_len = find_commit_subject(buf, &subject_start);
 		if (subject_len)

-- 
2.16.3

brian m. carlson· Mar 25, 2018, 15:20 UTC · re: René Scharfe · lore

Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:

Show 6 quoted lines

> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
> object to object_id).

This looks good to me.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204

Junio C Hamano· Mar 25, 2018, 16:48 UTC · re: brian m. carlson · lore

Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 9 quoted lines

> On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:
>> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
>> 
>> Signed-off-by: Rene Scharfe <l.s.r@web.de>
>> ---
>> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
>> object to object_id).
>
> This looks good to me.

Thanks.