{"thread":{"id":"48138","subject":"[PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings","startedAt":"2018-03-25T10:57:54Z","lastAt":"2018-03-25T16:48:34Z","messageCount":3,"participants":["René Scharfe","brian m. carlson","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"342882","messageId":"9839073c-84ca-f00e-d0e1-801e521ef29e@web.de","threadId":"48138","inReplyTo":null,"subject":"[PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2018-03-25T10:57:36Z","receivedAt":"2018-03-25T10:57:54Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.\n\nSigned-off-by: Rene Scharfe <l.s.r@web.de>\n---\nThis is a belated follow-up to f0a6068a9f (bisect: debug: convert struct\nobject to object_id).\n\n bisect.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/bisect.c b/bisect.c\nindex f6d05bd66f..319d60edad 100644\n--- a/bisect.c\n+++ b/bisect.c\n@@ -144,10 +144,10 @@ static void show_list(const char *debug, int counted, int nr,\n \t\t\tfprintf(stderr, \"%3d\", weight(p));\n \t\telse\n \t\t\tfprintf(stderr, \"---\");\n-\t\tfprintf(stderr, \" %.*s\", 8, sha1_to_hex(commit->object.oid.hash));\n+\t\tfprintf(stderr, \" %.*s\", 8, oid_to_hex(&commit->object.oid));\n \t\tfor (pp = commit->parents; pp; pp = pp->next)\n \t\t\tfprintf(stderr, \" %.*s\", 8,\n-\t\t\t\tsha1_to_hex(pp->item->object.oid.hash));\n+\t\t\t\toid_to_hex(&pp->item->object.oid));\n \n \t\tsubject_len = find_commit_subject(buf, &subject_start);\n \t\tif (subject_len)\n-- \n2.16.3\n"},{"id":"342893","messageId":"20180325152022.GD74743@genre.crustytoothpaste.net","threadId":"48138","inReplyTo":"9839073c-84ca-f00e-d0e1-801e521ef29e@web.de","subject":"Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2018-03-25T15:20:22Z","receivedAt":"2018-03-25T15:20:37Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:\n> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.\n> \n> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n> ---\n> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct\n> object to object_id).\n\nThis looks good to me.\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\nhttps://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: https://keybase.io/bk2204\n"},{"id":"342900","messageId":"xmqqfu4of6eb.fsf@gitster-ct.c.googlers.com","threadId":"48138","inReplyTo":"20180325152022.GD74743@genre.crustytoothpaste.net","subject":"Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-03-25T16:48:28Z","receivedAt":"2018-03-25T16:48:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" <sandals@crustytoothpaste.net> writes:\n\n> On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote:\n>> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.\n>> \n>> Signed-off-by: Rene Scharfe <l.s.r@web.de>\n>> ---\n>> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct\n>> object to object_id).\n>\n> This looks good to me.\n\nThanks.\n"}]}