git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings

From
René Scharfe <l.s.r@web.de>
Date
Mar 25, 2018, 10:57 UTC
Message-ID
<9839073c-84ca-f00e-d0e1-801e521ef29e@web.de>
Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct
object to object_id).
 bisect.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/bisect.c b/bisect.c
index f6d05bd66f..319d60edad 100644
--- a/bisect.c
+++ b/bisect.c
@@ -144,10 +144,10 @@ static void show_list(const char *debug, int counted, int nr,
 			fprintf(stderr, "%3d", weight(p));
 		else
 			fprintf(stderr, "---");
-		fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.oid.hash));
+		fprintf(stderr, " %.*s", 8, oid_to_hex(&commit->object.oid));
 		for (pp = commit->parents; pp; pp = pp->next)
 			fprintf(stderr, " %.*s", 8,
-				sha1_to_hex(pp->item->object.oid.hash));
+				oid_to_hex(&pp->item->object.oid));
 
 		subject_len = find_commit_subject(buf, &subject_start);
 		if (subject_len)
-- 
2.16.3
Next: brian m. carlson
Message 1 of 3 in “bisect: use oid_to_hex() for converting object_id hashes to hex strings”
  1. bisect: use oid_to_hex() for converting object_id hashes to hex stringsRené Scharfe, Mar 25, 2018
  2. brian m. carlsonMar 25, 2018
  3. Junio C HamanoMar 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.