# [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings 3 messages from 2018-03-25 to 2018-03-25. Participants: René Scharfe, brian m. carlson, Junio C Hamano. Thread: https://gitlist.dev/t/48138 ## René Scharfe, 2018-03-25 10:57 Subject: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings Message-ID: <9839073c-84ca-f00e-d0e1-801e521ef29e@web.de> URL: https://gitlist.dev/e/9839073c-84ca-f00e-d0e1-801e521ef29e%40web.de ``` Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci. Signed-off-by: Rene Scharfe --- This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct object to object_id). bisect.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bisect.c b/bisect.c index f6d05bd66f..319d60edad 100644 --- a/bisect.c +++ b/bisect.c @@ -144,10 +144,10 @@ static void show_list(const char *debug, int counted, int nr, fprintf(stderr, "%3d", weight(p)); else fprintf(stderr, "---"); - fprintf(stderr, " %.*s", 8, sha1_to_hex(commit->object.oid.hash)); + fprintf(stderr, " %.*s", 8, oid_to_hex(&commit->object.oid)); for (pp = commit->parents; pp; pp = pp->next) fprintf(stderr, " %.*s", 8, - sha1_to_hex(pp->item->object.oid.hash)); + oid_to_hex(&pp->item->object.oid)); subject_len = find_commit_subject(buf, &subject_start); if (subject_len) -- 2.16.3 ``` ## brian m. carlson, 2018-03-25 15:20 Subject: Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings Message-ID: <20180325152022.GD74743@genre.crustytoothpaste.net> URL: https://gitlist.dev/e/20180325152022.GD74743%40genre.crustytoothpaste.net In-Reply-To: <9839073c-84ca-f00e-d0e1-801e521ef29e@web.de> ``` On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote: > Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci. > > Signed-off-by: Rene Scharfe > --- > This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct > object to object_id). This looks good to me. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204 ``` ## Junio C Hamano, 2018-03-25 16:48 Subject: Re: [PATCH] bisect: use oid_to_hex() for converting object_id hashes to hex strings Message-ID: URL: https://gitlist.dev/e/xmqqfu4of6eb.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20180325152022.GD74743@genre.crustytoothpaste.net> ``` "brian m. carlson" writes: > On Sun, Mar 25, 2018 at 12:57:36PM +0200, René Scharfe wrote: >> Patch generated with Coccinelle and contrib/coccinelle/object_id.cocci. >> >> Signed-off-by: Rene Scharfe >> --- >> This is a belated follow-up to f0a6068a9f (bisect: debug: convert struct >> object to object_id). > > This looks good to me. Thanks. ```