threads / discuss / 47287

doc: prefer 'stash push' over 'stash save'

Subject: doc: prefer 'stash push' over 'stash save'

## tl;dr

4 messages between Nov 21, 2017 and Nov 22, 2017.

replies: 3people: 3as markdown or json

Phil Hord· Nov 21, 2017, 23:05 UTC · lore

Although `git stash save` was deprecated recently, some parts of the documentation still refer to it instead of `push`.

Signed-off-by: Phil Hord <phil.hord@gmail.com>
---
 Documentation/git-stash.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
index 8be661007..056dfb866 100644
--- a/Documentation/git-stash.txt
+++ b/Documentation/git-stash.txt
@@ -175,14 +175,14 @@ create::
  return its object name, without storing it anywhere in the ref
  namespace.
  This is intended to be useful for scripts.  It is probably not
- the command you want to use; see "save" above.
+ the command you want to use; see "push" above.

 store::

  Store a given stash created via 'git stash create' (which is a
  dangling merge commit) in the stash ref, updating the stash
  reflog.  This is intended to be useful for scripts.  It is
- probably not the command you want to use; see "save" above.
+ probably not the command you want to use; see "push" above.

 DISCUSSION
 ----------

-- 
2.15.0.471.g17a719cfe.dirty
Jonathan Nieder· Nov 21, 2017, 23:21 UTC · re: Phil Hord · lore

Re: doc: prefer 'stash push' over 'stash save'

Phil Hord wrote:
Show 7 quoted lines
> Although `git stash save` was deprecated recently, some parts of the
> documentation still refer to it instead of `push`.
>
> Signed-off-by: Phil Hord <phil.hord@gmail.com>
> ---
>  Documentation/git-stash.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
Junio C Hamano· Nov 22, 2017, 04:39 UTC · re: Jonathan Nieder · lore

Re: doc: prefer 'stash push' over 'stash save'

Jonathan Nieder <jrnieder@gmail.com> writes:
Show 12 quoted lines
> Phil Hord wrote:
>
>> Although `git stash save` was deprecated recently, some parts of the
>> documentation still refer to it instead of `push`.
>>
>> Signed-off-by: Phil Hord <phil.hord@gmail.com>
>> ---
>>  Documentation/git-stash.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> Thanks.

Heh, this does not even apply to 8be661007 that it claims to apply on top of, which is contained in fd2ebf14 ("stash: mark "git stash save" deprecated in the man page", 2017-10-22).

I've wiggled it in, so there is no need to resend, but next time please be careful when sending the patch and also when sending a reviewed-by.

Phil Hord· Nov 22, 2017, 16:41 UTC · re: Junio C Hamano · lore

Re: doc: prefer 'stash push' over 'stash save'

You probably already noticed this was my fault for filtering the patch through Gmail's GUI. I did also push a replacement which hopefully does apply.

On Tue, Nov 21, 2017 at 8:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Phil Hord wrote:
>>
>>> Although `git stash save` was deprecated recently, some parts of the
>>> documentation still refer to it instead of `push`.
>>>
>>> Signed-off-by: Phil Hord <phil.hord@gmail.com>
>>> ---
>>>  Documentation/git-stash.txt | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>> Thanks.
>
> Heh, this does not even apply to 8be661007 that it claims to apply
> on top of, which is contained in fd2ebf14 ("stash: mark "git stash
> save" deprecated in the man page", 2017-10-22).
>
> I've wiggled it in, so there is no need to resend, but next time
> please be careful when sending the patch and also when sending a
> reviewed-by.

← back to recent threads