Re: doc: prefer 'stash push' over 'stash save'
- From
Phil Hord <phil.hord@gmail.com>
- Date
- Nov 22, 2017, 16:41 UTC
- Message-ID
- <CABURp0r6JQ9ehs+_h4XcNkHmEVogJ7b8UKSte_Ytxe0+ziiA2g@mail.gmail.com>
- In-Reply-To
- <xmqqlgizudto.fsf@gitster.mtv.corp.google.com>
You probably already noticed this was my fault for filtering the patch through Gmail's GUI. I did also push a replacement which hopefully does apply.
On Tue, Nov 21, 2017 at 8:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 22 quoted lines
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> Phil Hord wrote:
>>
>>> Although `git stash save` was deprecated recently, some parts of the
>>> documentation still refer to it instead of `push`.
>>>
>>> Signed-off-by: Phil Hord <phil.hord@gmail.com>
>>> ---
>>> Documentation/git-stash.txt | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>> Thanks.
>
> Heh, this does not even apply to 8be661007 that it claims to apply
> on top of, which is contained in fd2ebf14 ("stash: mark "git stash
> save" deprecated in the man page", 2017-10-22).
>
> I've wiggled it in, so there is no need to resend, but next time
> please be careful when sending the patch and also when sending a
> reviewed-by.