# doc: prefer 'stash push' over 'stash save' 4 messages from 2017-11-21 to 2017-11-22. Participants: Phil Hord, Jonathan Nieder, Junio C Hamano. Thread: https://gitlist.dev/t/47287 ## Phil Hord, 2017-11-21 23:05 Subject: doc: prefer 'stash push' over 'stash save' Message-ID: URL: https://gitlist.dev/e/CABURp0pxYiwrpvT9E_jpvZKDMOUVA9e7dUhARfKEQymWzUwtiw%40mail.gmail.com ``` Although `git stash save` was deprecated recently, some parts of the documentation still refer to it instead of `push`. Signed-off-by: Phil Hord --- Documentation/git-stash.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt index 8be661007..056dfb866 100644 --- a/Documentation/git-stash.txt +++ b/Documentation/git-stash.txt @@ -175,14 +175,14 @@ create:: return its object name, without storing it anywhere in the ref namespace. This is intended to be useful for scripts. It is probably not - the command you want to use; see "save" above. + the command you want to use; see "push" above. store:: Store a given stash created via 'git stash create' (which is a dangling merge commit) in the stash ref, updating the stash reflog. This is intended to be useful for scripts. It is - probably not the command you want to use; see "save" above. + probably not the command you want to use; see "push" above. DISCUSSION ---------- -- 2.15.0.471.g17a719cfe.dirty ``` ## Jonathan Nieder, 2017-11-21 23:21 Subject: Re: doc: prefer 'stash push' over 'stash save' Message-ID: <20171121232113.GK3429@aiede.mtv.corp.google.com> URL: https://gitlist.dev/e/20171121232113.GK3429%40aiede.mtv.corp.google.com In-Reply-To: ``` Phil Hord wrote: > Although `git stash save` was deprecated recently, some parts of the > documentation still refer to it instead of `push`. > > Signed-off-by: Phil Hord > --- > Documentation/git-stash.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jonathan Nieder Thanks. ``` ## Junio C Hamano, 2017-11-22 04:39 Subject: Re: doc: prefer 'stash push' over 'stash save' Message-ID: URL: https://gitlist.dev/e/xmqqlgizudto.fsf%40gitster.mtv.corp.google.com In-Reply-To: <20171121232113.GK3429@aiede.mtv.corp.google.com> ``` Jonathan Nieder writes: > Phil Hord wrote: > >> Although `git stash save` was deprecated recently, some parts of the >> documentation still refer to it instead of `push`. >> >> Signed-off-by: Phil Hord >> --- >> Documentation/git-stash.txt | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Jonathan Nieder > Thanks. Heh, this does not even apply to 8be661007 that it claims to apply on top of, which is contained in fd2ebf14 ("stash: mark "git stash save" deprecated in the man page", 2017-10-22). I've wiggled it in, so there is no need to resend, but next time please be careful when sending the patch and also when sending a reviewed-by. ``` ## Phil Hord, 2017-11-22 16:41 Subject: Re: doc: prefer 'stash push' over 'stash save' Message-ID: URL: https://gitlist.dev/e/CABURp0r6JQ9ehs%2B_h4XcNkHmEVogJ7b8UKSte_Ytxe0%2BziiA2g%40mail.gmail.com In-Reply-To: ``` You probably already noticed this was my fault for filtering the patch through Gmail's GUI. I did also push a replacement which hopefully does apply. On Tue, Nov 21, 2017 at 8:39 PM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> Phil Hord wrote: >> >>> Although `git stash save` was deprecated recently, some parts of the >>> documentation still refer to it instead of `push`. >>> >>> Signed-off-by: Phil Hord >>> --- >>> Documentation/git-stash.txt | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Reviewed-by: Jonathan Nieder >> Thanks. > > Heh, this does not even apply to 8be661007 that it claims to apply > on top of, which is contained in fd2ebf14 ("stash: mark "git stash > save" deprecated in the man page", 2017-10-22). > > I've wiggled it in, so there is no need to resend, but next time > please be careful when sending the patch and also when sending a > reviewed-by. ```