{"thread":{"id":"47287","subject":"doc: prefer 'stash push' over 'stash save'","startedAt":"2017-11-21T23:05:51Z","lastAt":"2017-11-22T16:41:51Z","messageCount":4,"participants":["Phil Hord","Jonathan Nieder","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"333184","messageId":"CABURp0pxYiwrpvT9E_jpvZKDMOUVA9e7dUhARfKEQymWzUwtiw@mail.gmail.com","threadId":"47287","inReplyTo":null,"subject":"doc: prefer 'stash push' over 'stash save'","fromName":"Phil Hord","fromEmail":"phil.hord@gmail.com","sentAt":"2017-11-21T23:05:23Z","receivedAt":"2017-11-21T23:05:51Z","isPatch":false,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"Although `git stash save` was deprecated recently, some parts of the\ndocumentation still refer to it instead of `push`.\n\nSigned-off-by: Phil Hord <phil.hord@gmail.com>\n---\n Documentation/git-stash.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt\nindex 8be661007..056dfb866 100644\n--- a/Documentation/git-stash.txt\n+++ b/Documentation/git-stash.txt\n@@ -175,14 +175,14 @@ create::\n  return its object name, without storing it anywhere in the ref\n  namespace.\n  This is intended to be useful for scripts.  It is probably not\n- the command you want to use; see \"save\" above.\n+ the command you want to use; see \"push\" above.\n\n store::\n\n  Store a given stash created via 'git stash create' (which is a\n  dangling merge commit) in the stash ref, updating the stash\n  reflog.  This is intended to be useful for scripts.  It is\n- probably not the command you want to use; see \"save\" above.\n+ probably not the command you want to use; see \"push\" above.\n\n DISCUSSION\n ----------\n-- \n2.15.0.471.g17a719cfe.dirty\n"},{"id":"333188","messageId":"20171121232113.GK3429@aiede.mtv.corp.google.com","threadId":"47287","inReplyTo":"CABURp0pxYiwrpvT9E_jpvZKDMOUVA9e7dUhARfKEQymWzUwtiw@mail.gmail.com","subject":"Re: doc: prefer 'stash push' over 'stash save'","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-11-21T23:21:13Z","receivedAt":"2017-11-21T23:21:21Z","isPatch":false,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Phil Hord wrote:\n\n> Although `git stash save` was deprecated recently, some parts of the\n> documentation still refer to it instead of `push`.\n>\n> Signed-off-by: Phil Hord <phil.hord@gmail.com>\n> ---\n>  Documentation/git-stash.txt | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\nThanks.\n"},{"id":"333239","messageId":"xmqqlgizudto.fsf@gitster.mtv.corp.google.com","threadId":"47287","inReplyTo":"20171121232113.GK3429@aiede.mtv.corp.google.com","subject":"Re: doc: prefer 'stash push' over 'stash save'","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-11-22T04:39:31Z","receivedAt":"2017-11-22T04:39:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Phil Hord wrote:\n>\n>> Although `git stash save` was deprecated recently, some parts of the\n>> documentation still refer to it instead of `push`.\n>>\n>> Signed-off-by: Phil Hord <phil.hord@gmail.com>\n>> ---\n>>  Documentation/git-stash.txt | 4 ++--\n>>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n> Thanks.\n\nHeh, this does not even apply to 8be661007 that it claims to apply\non top of, which is contained in fd2ebf14 (\"stash: mark \"git stash\nsave\" deprecated in the man page\", 2017-10-22).\n\nI've wiggled it in, so there is no need to resend, but next time\nplease be careful when sending the patch and also when sending a\nreviewed-by.\n"},{"id":"333290","messageId":"CABURp0r6JQ9ehs+_h4XcNkHmEVogJ7b8UKSte_Ytxe0+ziiA2g@mail.gmail.com","threadId":"47287","inReplyTo":"xmqqlgizudto.fsf@gitster.mtv.corp.google.com","subject":"Re: doc: prefer 'stash push' over 'stash save'","fromName":"Phil Hord","fromEmail":"phil.hord@gmail.com","sentAt":"2017-11-22T16:41:24Z","receivedAt":"2017-11-22T16:41:51Z","isPatch":false,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"You probably already noticed this was my fault for filtering the patch\nthrough Gmail's GUI.  I did also push a replacement which hopefully\ndoes apply.\n\nOn Tue, Nov 21, 2017 at 8:39 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Jonathan Nieder <jrnieder@gmail.com> writes:\n>\n>> Phil Hord wrote:\n>>\n>>> Although `git stash save` was deprecated recently, some parts of the\n>>> documentation still refer to it instead of `push`.\n>>>\n>>> Signed-off-by: Phil Hord <phil.hord@gmail.com>\n>>> ---\n>>>  Documentation/git-stash.txt | 4 ++--\n>>>  1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n>> Thanks.\n>\n> Heh, this does not even apply to 8be661007 that it claims to apply\n> on top of, which is contained in fd2ebf14 (\"stash: mark \"git stash\n> save\" deprecated in the man page\", 2017-10-22).\n>\n> I've wiggled it in, so there is no need to resend, but next time\n> please be careful when sending the patch and also when sending a\n> reviewed-by.\n"}]}