threads / patch / 46981

patchfetch doc: src side of refspec could be full SHA-1

Subject: [PATCH] fetch doc: src side of refspec could be full SHA-1

## tl;dr

3 messages between Oct 17, 2017 and Oct 17, 2017. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Junio C Hamano· Oct 17, 2017, 03:56 UTC · lore

Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we allow to fetch by an object name when the other side accepts such a request, but we never updated the documentation to match.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/pull-fetch-param.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Show changes to Documentation/pull-fetch-param.txt +4 −2

diff --git a/Documentation/pull-fetch-param.txt b/Documentation/pull-fetch-param.txt
index 1ebbf1d738..733f932479 100644
--- a/Documentation/pull-fetch-param.txt
+++ b/Documentation/pull-fetch-param.txt
@@ -23,9 +23,11 @@ ifdef::git-pull[]
 endif::git-pull[]
 +
 The format of a <refspec> parameter is an optional plus
-`+`, followed by the source ref <src>, followed
+`+`, followed by the source <src>, followed
 by a colon `:`, followed by the destination ref <dst>.
-The colon can be omitted when <dst> is empty.
+The colon can be omitted when <dst> is empty.  <src> is most
+typically a ref, but it can also be an fully spelled hex object
+name.
 +
 `tag <tag>` means the same as `refs/tags/<tag>:refs/tags/<tag>`;
 it requests fetching everything up to the given tag.

-- 
2.15.0-rc1-168-g2b9456ab46

Jonathan Nieder· Oct 17, 2017, 19:35 UTC · re: Junio C Hamano · lore

Re: [PATCH] fetch doc: src side of refspec could be full SHA-1

Hi Junio,

Junio C Hamano wrote:

Show 8 quoted lines

> Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we
> allow to fetch by an object name when the other side accepts such a
> request, but we never updated the documentation to match.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Documentation/pull-fetch-param.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Good catch.

Show 13 quoted lines

> --- a/Documentation/pull-fetch-param.txt
> +++ b/Documentation/pull-fetch-param.txt
> @@ -23,9 +23,11 @@ ifdef::git-pull[]
>  endif::git-pull[]
>  +
>  The format of a <refspec> parameter is an optional plus
> -`+`, followed by the source ref <src>, followed
> +`+`, followed by the source <src>, followed
>  by a colon `:`, followed by the destination ref <dst>.
> -The colon can be omitted when <dst> is empty.
> +The colon can be omitted when <dst> is empty.  <src> is most
> +typically a ref, but it can also be an fully spelled hex object
> +name.

nits:

s/most typically/typically/ s/an fully/a fully/

With those tweaks,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

Junio C Hamano· Oct 17, 2017, 21:00 UTC · re: Jonathan Nieder · lore

Re: [PATCH] fetch doc: src side of refspec could be full SHA-1

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 7 quoted lines

> nits:
>
> s/most typically/typically/
> s/an fully/a fully/
>
> With those tweaks,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.