# [PATCH] fetch doc: src side of refspec could be full SHA-1

3 messages from 2017-10-17 to 2017-10-17. Participants: Junio C Hamano, Jonathan Nieder.
Thread: https://gitlist.dev/t/46981

## Junio C Hamano, 2017-10-17 03:56

Subject: [PATCH] fetch doc: src side of refspec could be full SHA-1
Message-ID: <xmqqinfepguv.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqinfepguv.fsf%40gitster.mtv.corp.google.com

```
Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we
allow to fetch by an object name when the other side accepts such a
request, but we never updated the documentation to match.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 Documentation/pull-fetch-param.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/pull-fetch-param.txt b/Documentation/pull-fetch-param.txt
index 1ebbf1d738..733f932479 100644
--- a/Documentation/pull-fetch-param.txt
+++ b/Documentation/pull-fetch-param.txt
@@ -23,9 +23,11 @@ ifdef::git-pull[]
 endif::git-pull[]
 +
 The format of a <refspec> parameter is an optional plus
-`+`, followed by the source ref <src>, followed
+`+`, followed by the source <src>, followed
 by a colon `:`, followed by the destination ref <dst>.
-The colon can be omitted when <dst> is empty.
+The colon can be omitted when <dst> is empty.  <src> is most
+typically a ref, but it can also be an fully spelled hex object
+name.
 +
 `tag <tag>` means the same as `refs/tags/<tag>:refs/tags/<tag>`;
 it requests fetching everything up to the given tag.
-- 
2.15.0-rc1-168-g2b9456ab46


```

## Jonathan Nieder, 2017-10-17 19:35

Subject: Re: [PATCH] fetch doc: src side of refspec could be full SHA-1
Message-ID: <20171017193511.szbmrclju22a6p5l@aiede.mtv.corp.google.com>
URL: https://gitlist.dev/e/20171017193511.szbmrclju22a6p5l%40aiede.mtv.corp.google.com
In-Reply-To: <xmqqinfepguv.fsf@gitster.mtv.corp.google.com>

```
Hi Junio,

Junio C Hamano wrote:

> Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we
> allow to fetch by an object name when the other side accepts such a
> request, but we never updated the documentation to match.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Documentation/pull-fetch-param.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Good catch.

> --- a/Documentation/pull-fetch-param.txt
> +++ b/Documentation/pull-fetch-param.txt
> @@ -23,9 +23,11 @@ ifdef::git-pull[]
>  endif::git-pull[]
>  +
>  The format of a <refspec> parameter is an optional plus
> -`+`, followed by the source ref <src>, followed
> +`+`, followed by the source <src>, followed
>  by a colon `:`, followed by the destination ref <dst>.
> -The colon can be omitted when <dst> is empty.
> +The colon can be omitted when <dst> is empty.  <src> is most
> +typically a ref, but it can also be an fully spelled hex object
> +name.

nits:

s/most typically/typically/
s/an fully/a fully/

With those tweaks,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

```

## Junio C Hamano, 2017-10-17 21:00

Subject: Re: [PATCH] fetch doc: src side of refspec could be full SHA-1
Message-ID: <xmqqwp3tmqvy.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqwp3tmqvy.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <20171017193511.szbmrclju22a6p5l@aiede.mtv.corp.google.com>

```
Jonathan Nieder <jrnieder@gmail.com> writes:

> nits:
>
> s/most typically/typically/
> s/an fully/a fully/
>
> With those tweaks,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.

```