Re: [PATCH] fetch doc: src side of refspec could be full SHA-1

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 17, 2017, 19:35 UTC
Message-ID: <20171017193511.szbmrclju22a6p5l@aiede.mtv.corp.google.com>
In-Reply-To: <xmqqinfepguv.fsf@gitster.mtv.corp.google.com>

Hi Junio,

Junio C Hamano wrote:

Show 8 quoted lines

> Since a9d34933 ("Merge branch 'fm/fetch-raw-sha1'", 2015-06-01) we
> allow to fetch by an object name when the other side accepts such a
> request, but we never updated the documentation to match.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  Documentation/pull-fetch-param.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Good catch.

Show 13 quoted lines

> --- a/Documentation/pull-fetch-param.txt
> +++ b/Documentation/pull-fetch-param.txt
> @@ -23,9 +23,11 @@ ifdef::git-pull[]
>  endif::git-pull[]
>  +
>  The format of a <refspec> parameter is an optional plus
> -`+`, followed by the source ref <src>, followed
> +`+`, followed by the source <src>, followed
>  by a colon `:`, followed by the destination ref <dst>.
> -The colon can be omitted when <dst> is empty.
> +The colon can be omitted when <dst> is empty.  <src> is most
> +typically a ref, but it can also be an fully spelled hex object
> +name.

nits:

s/most typically/typically/ s/an fully/a fully/

With those tweaks,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.