{"thread":{"id":"46981","subject":"[PATCH] fetch doc: src side of refspec could be full SHA-1","startedAt":"2017-10-17T03:56:32Z","lastAt":"2017-10-17T21:00:24Z","messageCount":3,"participants":["Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"330511","messageId":"xmqqinfepguv.fsf@gitster.mtv.corp.google.com","threadId":"46981","inReplyTo":null,"subject":"[PATCH] fetch doc: src side of refspec could be full SHA-1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-10-17T03:56:24Z","receivedAt":"2017-10-17T03:56:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Since a9d34933 (\"Merge branch 'fm/fetch-raw-sha1'\", 2015-06-01) we\nallow to fetch by an object name when the other side accepts such a\nrequest, but we never updated the documentation to match.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n Documentation/pull-fetch-param.txt | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/pull-fetch-param.txt b/Documentation/pull-fetch-param.txt\nindex 1ebbf1d738..733f932479 100644\n--- a/Documentation/pull-fetch-param.txt\n+++ b/Documentation/pull-fetch-param.txt\n@@ -23,9 +23,11 @@ ifdef::git-pull[]\n endif::git-pull[]\n +\n The format of a <refspec> parameter is an optional plus\n-`+`, followed by the source ref <src>, followed\n+`+`, followed by the source <src>, followed\n by a colon `:`, followed by the destination ref <dst>.\n-The colon can be omitted when <dst> is empty.\n+The colon can be omitted when <dst> is empty.  <src> is most\n+typically a ref, but it can also be an fully spelled hex object\n+name.\n +\n `tag <tag>` means the same as `refs/tags/<tag>:refs/tags/<tag>`;\n it requests fetching everything up to the given tag.\n-- \n2.15.0-rc1-168-g2b9456ab46\n\n"},{"id":"330567","messageId":"20171017193511.szbmrclju22a6p5l@aiede.mtv.corp.google.com","threadId":"46981","inReplyTo":"xmqqinfepguv.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] fetch doc: src side of refspec could be full SHA-1","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-10-17T19:35:11Z","receivedAt":"2017-10-17T19:35:20Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Junio,\n\nJunio C Hamano wrote:\n\n> Since a9d34933 (\"Merge branch 'fm/fetch-raw-sha1'\", 2015-06-01) we\n> allow to fetch by an object name when the other side accepts such a\n> request, but we never updated the documentation to match.\n>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n>  Documentation/pull-fetch-param.txt | 6 ++++--\n>  1 file changed, 4 insertions(+), 2 deletions(-)\n\nGood catch.\n\n> --- a/Documentation/pull-fetch-param.txt\n> +++ b/Documentation/pull-fetch-param.txt\n> @@ -23,9 +23,11 @@ ifdef::git-pull[]\n>  endif::git-pull[]\n>  +\n>  The format of a <refspec> parameter is an optional plus\n> -`+`, followed by the source ref <src>, followed\n> +`+`, followed by the source <src>, followed\n>  by a colon `:`, followed by the destination ref <dst>.\n> -The colon can be omitted when <dst> is empty.\n> +The colon can be omitted when <dst> is empty.  <src> is most\n> +typically a ref, but it can also be an fully spelled hex object\n> +name.\n\nnits:\n\ns/most typically/typically/\ns/an fully/a fully/\n\nWith those tweaks,\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks.\n"},{"id":"330571","messageId":"xmqqwp3tmqvy.fsf@gitster.mtv.corp.google.com","threadId":"46981","inReplyTo":"20171017193511.szbmrclju22a6p5l@aiede.mtv.corp.google.com","subject":"Re: [PATCH] fetch doc: src side of refspec could be full SHA-1","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-10-17T21:00:17Z","receivedAt":"2017-10-17T21:00:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> nits:\n>\n> s/most typically/typically/\n> s/an fully/a fully/\n>\n> With those tweaks,\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\nThanks.\n"}]}