threads / patch / 45052

patchp5302: create repositories for index-pack results explicitly

Subject: [PATCH] p5302: create repositories for index-pack results explicitly

## tl;dr

2 messages between Feb 5, 2017 and Feb 6, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

René Scharfe· Feb 5, 2017, 11:43 UTC · lore

Before 7176a314 (index-pack: complain when --stdin is used outside of a repo) index-pack silently created a non-existing target directory; now the command refuses to work unless it's used against a valid repository. That causes p5302 to fail, which relies on the former behavior. Fix it by setting up the destinations for its performance tests using git init.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
 t/perf/p5302-pack-index.sh | 7 +++++++
 1 file changed, 7 insertions(+)

Show changes to t/perf/p5302-pack-index.sh +7 −0

diff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh
index 5ee9211f98..99bdb16c85 100755
--- a/t/perf/p5302-pack-index.sh
+++ b/t/perf/p5302-pack-index.sh
@@ -13,6 +13,13 @@ test_expect_success 'repack' '
 	export PACK
 '
 
+test_expect_success 'create target repositories' '
+	for repo in t1 t2 t3 t4 t5 t6
+	do
+		git init --bare $repo
+	done
+'
+
 test_perf 'index-pack 0 threads' '
 	GIT_DIR=t1 git index-pack --threads=1 --stdin < $PACK
 '

-- 
2.11.1

Jeff King· Feb 6, 2017, 14:41 UTC · re: René Scharfe · lore

Re: [PATCH] p5302: create repositories for index-pack results explicitly

On Sun, Feb 05, 2017 at 12:43:29PM +0100, René Scharfe wrote:

Show 5 quoted lines

> Before 7176a314 (index-pack: complain when --stdin is used outside of a
> repo) index-pack silently created a non-existing target directory; now
> the command refuses to work unless it's used against a valid repository.
> That causes p5302 to fail, which relies on the former behavior.  Fix it
> by setting up the destinations for its performance tests using git init.

Ah, right. Thanks for catching this.

I think p5302 was wrong to rely on the old behavior, and your patch is the right fix.

-Peff