Re: [PATCH] p5302: create repositories for index-pack results explicitly
- From
Jeff King <peff@peff.net>
- Date
- Feb 6, 2017, 14:41 UTC
- Message-ID
- <20170206144121.hrptyubhtjoyohfl@sigill.intra.peff.net>
- In-Reply-To
- <251bdc20-19a7-9a6c-9f5a-c7e661810c70@web.de>
On Sun, Feb 05, 2017 at 12:43:29PM +0100, René Scharfe wrote:
Show 5 quoted lines
> Before 7176a314 (index-pack: complain when --stdin is used outside of a > repo) index-pack silently created a non-existing target directory; now > the command refuses to work unless it's used against a valid repository. > That causes p5302 to fail, which relies on the former behavior. Fix it > by setting up the destinations for its performance tests using git init.
Ah, right. Thanks for catching this.
I think p5302 was wrong to rely on the old behavior, and your patch is the right fix.
-Peff