# [PATCH] p5302: create repositories for index-pack results explicitly 2 messages from 2017-02-05 to 2017-02-06. Participants: René Scharfe, Jeff King. Thread: https://gitlist.dev/t/45052 ## René Scharfe, 2017-02-05 11:43 Subject: [PATCH] p5302: create repositories for index-pack results explicitly Message-ID: <251bdc20-19a7-9a6c-9f5a-c7e661810c70@web.de> URL: https://gitlist.dev/e/251bdc20-19a7-9a6c-9f5a-c7e661810c70%40web.de ``` Before 7176a314 (index-pack: complain when --stdin is used outside of a repo) index-pack silently created a non-existing target directory; now the command refuses to work unless it's used against a valid repository. That causes p5302 to fail, which relies on the former behavior. Fix it by setting up the destinations for its performance tests using git init. Signed-off-by: Rene Scharfe --- t/perf/p5302-pack-index.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh index 5ee9211f98..99bdb16c85 100755 --- a/t/perf/p5302-pack-index.sh +++ b/t/perf/p5302-pack-index.sh @@ -13,6 +13,13 @@ test_expect_success 'repack' ' export PACK ' +test_expect_success 'create target repositories' ' + for repo in t1 t2 t3 t4 t5 t6 + do + git init --bare $repo + done +' + test_perf 'index-pack 0 threads' ' GIT_DIR=t1 git index-pack --threads=1 --stdin < $PACK ' -- 2.11.1 ``` ## Jeff King, 2017-02-06 14:41 Subject: Re: [PATCH] p5302: create repositories for index-pack results explicitly Message-ID: <20170206144121.hrptyubhtjoyohfl@sigill.intra.peff.net> URL: https://gitlist.dev/e/20170206144121.hrptyubhtjoyohfl%40sigill.intra.peff.net In-Reply-To: <251bdc20-19a7-9a6c-9f5a-c7e661810c70@web.de> ``` On Sun, Feb 05, 2017 at 12:43:29PM +0100, René Scharfe wrote: > Before 7176a314 (index-pack: complain when --stdin is used outside of a > repo) index-pack silently created a non-existing target directory; now > the command refuses to work unless it's used against a valid repository. > That causes p5302 to fail, which relies on the former behavior. Fix it > by setting up the destinations for its performance tests using git init. Ah, right. Thanks for catching this. I think p5302 was wrong to rely on the old behavior, and your patch is the right fix. -Peff ```