{"thread":{"id":"45052","subject":"[PATCH] p5302: create repositories for index-pack results explicitly","startedAt":"2017-02-05T11:49:03Z","lastAt":"2017-02-06T14:41:36Z","messageCount":2,"participants":["René Scharfe","Jeff King"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"310872","messageId":"251bdc20-19a7-9a6c-9f5a-c7e661810c70@web.de","threadId":"45052","inReplyTo":null,"subject":"[PATCH] p5302: create repositories for index-pack results explicitly","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2017-02-05T11:43:29Z","receivedAt":"2017-02-05T11:49:03Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Before 7176a314 (index-pack: complain when --stdin is used outside of a\nrepo) index-pack silently created a non-existing target directory; now\nthe command refuses to work unless it's used against a valid repository.\nThat causes p5302 to fail, which relies on the former behavior.  Fix it\nby setting up the destinations for its performance tests using git init.\n\nSigned-off-by: Rene Scharfe <l.s.r@web.de>\n---\n t/perf/p5302-pack-index.sh | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/t/perf/p5302-pack-index.sh b/t/perf/p5302-pack-index.sh\nindex 5ee9211f98..99bdb16c85 100755\n--- a/t/perf/p5302-pack-index.sh\n+++ b/t/perf/p5302-pack-index.sh\n@@ -13,6 +13,13 @@ test_expect_success 'repack' '\n \texport PACK\n '\n \n+test_expect_success 'create target repositories' '\n+\tfor repo in t1 t2 t3 t4 t5 t6\n+\tdo\n+\t\tgit init --bare $repo\n+\tdone\n+'\n+\n test_perf 'index-pack 0 threads' '\n \tGIT_DIR=t1 git index-pack --threads=1 --stdin < $PACK\n '\n-- \n2.11.1\n\n"},{"id":"310911","messageId":"20170206144121.hrptyubhtjoyohfl@sigill.intra.peff.net","threadId":"45052","inReplyTo":"251bdc20-19a7-9a6c-9f5a-c7e661810c70@web.de","subject":"Re: [PATCH] p5302: create repositories for index-pack results explicitly","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-02-06T14:41:21Z","receivedAt":"2017-02-06T14:41:36Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Feb 05, 2017 at 12:43:29PM +0100, René Scharfe wrote:\n\n> Before 7176a314 (index-pack: complain when --stdin is used outside of a\n> repo) index-pack silently created a non-existing target directory; now\n> the command refuses to work unless it's used against a valid repository.\n> That causes p5302 to fail, which relies on the former behavior.  Fix it\n> by setting up the destinations for its performance tests using git init.\n\nAh, right. Thanks for catching this.\n\nI think p5302 was wrong to rely on the old behavior, and your patch is\nthe right fix.\n\n-Peff\n"}]}