threads / patch / 44083

patchpkt-line: mark a file-local symbol static

Subject: [PATCH] pkt-line: mark a file-local symbol static

## tl;dr

2 messages between Sep 14, 2016 and Sep 15, 2016. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Sep 14, 2016, 13:31 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Lars,

If you need to re-roll your 'ls/filter-process' branch, could you please squash this into the relevant patch; commit 2afd9b22 ("pkt-line: add packet_write_gently()", 08-09-2016).

[If you think the symbol should be public (I don't), then add a suitable declaration to pkt-line.h instead.]

Thanks!

ATB, Ramsay Jones

 pkt-line.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to pkt-line.c +1 −1

diff --git a/pkt-line.c b/pkt-line.c
index 538e35f..4900fc0 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -181,7 +181,7 @@ int packet_write_fmt_gently(int fd, const char *fmt, ...)
 	return status;
 }
 
-int packet_write_gently(const int fd_out, const char *buf, size_t size)
+static int packet_write_gently(const int fd_out, const char *buf, size_t size)
 {
 	static char packet_write_buffer[LARGE_PACKET_MAX];

-- 
2.10.0

Lars Schneider· Sep 15, 2016, 16:46 UTC · re: Ramsay Jones · lore

Re: [PATCH] pkt-line: mark a file-local symbol static

Show 17 quoted lines

> On 14 Sep 2016, at 14:31, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:
> 
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
> 
> Hi Lars,
> 
> If you need to re-roll your 'ls/filter-process' branch, could you
> please squash this into the relevant patch; commit 2afd9b22
> ("pkt-line: add packet_write_gently()", 08-09-2016).
> 
> [...]
> -int packet_write_gently(const int fd_out, const char *buf, size_t size)
> +static int packet_write_gently(const int fd_out, const char *buf, size_t size)
> {
> 	static char packet_write_buffer[LARGE_PACKET_MAX];

Done!

Thank you, Lars