git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] pkt-line: mark a file-local symbol static

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Sep 14, 2016, 13:31 UTC
Message-ID
<6373d68b-574d-59f3-7b8d-60dd3a673806@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Lars,

If you need to re-roll your 'ls/filter-process' branch, could you please squash this into the relevant patch; commit 2afd9b22 ("pkt-line: add packet_write_gently()", 08-09-2016).

[If you think the symbol should be public (I don't), then add a suitable declaration to pkt-line.h instead.]

Thanks!

ATB, Ramsay Jones

 pkt-line.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c
index 538e35f..4900fc0 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -181,7 +181,7 @@ int packet_write_fmt_gently(int fd, const char *fmt, ...)
 	return status;
 }
 
-int packet_write_gently(const int fd_out, const char *buf, size_t size)
+static int packet_write_gently(const int fd_out, const char *buf, size_t size)
 {
 	static char packet_write_buffer[LARGE_PACKET_MAX];
 
-- 
2.10.0
Next: Lars Schneider
Message 1 of 2 in “pkt-line: mark a file-local symbol static”
  1. pkt-line: mark a file-local symbol staticRamsay Jones, Sep 14, 2016
  2. Lars SchneiderSep 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.