# [PATCH] pkt-line: mark a file-local symbol static 2 messages from 2016-09-14 to 2016-09-15. Participants: Ramsay Jones, Lars Schneider. Thread: https://gitlist.dev/t/44083 ## Ramsay Jones, 2016-09-14 13:31 Subject: [PATCH] pkt-line: mark a file-local symbol static Message-ID: <6373d68b-574d-59f3-7b8d-60dd3a673806@ramsayjones.plus.com> URL: https://gitlist.dev/e/6373d68b-574d-59f3-7b8d-60dd3a673806%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Lars, If you need to re-roll your 'ls/filter-process' branch, could you please squash this into the relevant patch; commit 2afd9b22 ("pkt-line: add packet_write_gently()", 08-09-2016). [If you think the symbol should be public (I don't), then add a suitable declaration to pkt-line.h instead.] Thanks! ATB, Ramsay Jones pkt-line.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkt-line.c b/pkt-line.c index 538e35f..4900fc0 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -181,7 +181,7 @@ int packet_write_fmt_gently(int fd, const char *fmt, ...) return status; } -int packet_write_gently(const int fd_out, const char *buf, size_t size) +static int packet_write_gently(const int fd_out, const char *buf, size_t size) { static char packet_write_buffer[LARGE_PACKET_MAX]; -- 2.10.0 ``` ## Lars Schneider, 2016-09-15 16:46 Subject: Re: [PATCH] pkt-line: mark a file-local symbol static Message-ID: <86997B2A-EF9B-4DC2-84DE-785C1747B7CA@gmail.com> URL: https://gitlist.dev/e/86997B2A-EF9B-4DC2-84DE-785C1747B7CA%40gmail.com In-Reply-To: <6373d68b-574d-59f3-7b8d-60dd3a673806@ramsayjones.plus.com> ``` > On 14 Sep 2016, at 14:31, Ramsay Jones wrote: > > > Signed-off-by: Ramsay Jones > --- > > Hi Lars, > > If you need to re-roll your 'ls/filter-process' branch, could you > please squash this into the relevant patch; commit 2afd9b22 > ("pkt-line: add packet_write_gently()", 08-09-2016). > > [...] > -int packet_write_gently(const int fd_out, const char *buf, size_t size) > +static int packet_write_gently(const int fd_out, const char *buf, size_t size) > { > static char packet_write_buffer[LARGE_PACKET_MAX]; Done! Thank you, Lars ```