{"thread":{"id":"44083","subject":"[PATCH] pkt-line: mark a file-local symbol static","startedAt":"2016-09-14T13:31:48Z","lastAt":"2016-09-15T19:36:10Z","messageCount":2,"participants":["Ramsay Jones","Lars Schneider"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"301905","messageId":"6373d68b-574d-59f3-7b8d-60dd3a673806@ramsayjones.plus.com","threadId":"44083","inReplyTo":null,"subject":"[PATCH] pkt-line: mark a file-local symbol static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-09-14T13:31:24Z","receivedAt":"2016-09-14T13:31:48Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Lars,\n\nIf you need to re-roll your 'ls/filter-process' branch, could you\nplease squash this into the relevant patch; commit 2afd9b22\n(\"pkt-line: add packet_write_gently()\", 08-09-2016).\n\n[If you think the symbol should be public (I don't), then add a\nsuitable declaration to pkt-line.h instead.]\n\nThanks!\n\nATB,\nRamsay Jones\n\n pkt-line.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/pkt-line.c b/pkt-line.c\nindex 538e35f..4900fc0 100644\n--- a/pkt-line.c\n+++ b/pkt-line.c\n@@ -181,7 +181,7 @@ int packet_write_fmt_gently(int fd, const char *fmt, ...)\n \treturn status;\n }\n \n-int packet_write_gently(const int fd_out, const char *buf, size_t size)\n+static int packet_write_gently(const int fd_out, const char *buf, size_t size)\n {\n \tstatic char packet_write_buffer[LARGE_PACKET_MAX];\n \n-- \n2.10.0\n"},{"id":"302004","messageId":"86997B2A-EF9B-4DC2-84DE-785C1747B7CA@gmail.com","threadId":"44083","inReplyTo":"6373d68b-574d-59f3-7b8d-60dd3a673806@ramsayjones.plus.com","subject":"Re: [PATCH] pkt-line: mark a file-local symbol static","fromName":"Lars Schneider","fromEmail":"larsxschneider@gmail.com","sentAt":"2016-09-15T16:46:09Z","receivedAt":"2016-09-15T19:36:10Z","isPatch":true,"sender":{"key":"larsxschneider@gmail.com","avatar":"https://avatars.githubusercontent.com/u/477434?v=4"},"body":"\n> On 14 Sep 2016, at 14:31, Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:\n> \n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n> \n> Hi Lars,\n> \n> If you need to re-roll your 'ls/filter-process' branch, could you\n> please squash this into the relevant patch; commit 2afd9b22\n> (\"pkt-line: add packet_write_gently()\", 08-09-2016).\n> \n> [...]\n> -int packet_write_gently(const int fd_out, const char *buf, size_t size)\n> +static int packet_write_gently(const int fd_out, const char *buf, size_t size)\n> {\n> \tstatic char packet_write_buffer[LARGE_PACKET_MAX];\n\nDone!\n\nThank you,\nLars"}]}