threads / patch / 43381

patch, 4 partsRe: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

Subject: Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

## tl;dr

4 messages between Dec 4, 2006 and Dec 5, 2006. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Sam Vilain· Dec 4, 2006, 09:33 UTC · lore

[PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

Allow an extra parameter to be passed to the libsvn_ls_fullurl
function to collect and return the properties of the URL being listed.
---
 git-svn.perl |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

Show changes to git-svn.perl +4 −3

diff --git a/git-svn.perl b/git-svn.perl
index 3891122..93cfcc4 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3321,18 +3321,19 @@ sub libsvn_commit_cb {
 
 sub libsvn_ls_fullurl {
 	my $fullurl = shift;
+	my $want_props = shift;
 	my $ra = libsvn_connect($fullurl);
-	my @ret;
+	my (@ret, @props);
 	my $pool = SVN::Pool->new;
 	my $r = defined $_revision ? $_revision : $ra->get_latest_revnum;
-	my ($dirent, undef, undef) = $ra->get_dir('', $r, $pool);
+	my ($dirent, undef, $props) = $ra->get_dir('', $r, $pool);
 	foreach my $d (keys %$dirent) {
 		if ($dirent->{$d}->kind == $SVN::Node::dir) {
 			push @ret, "$d/"; # add '/' for compat with cli svn
 		}
 	}
 	$pool->clear;
-	return @ret;
+	return ($want_props ? (\@ret, $props) : @ret);
 }

-- 
1.4.4.1.ge918e-dirty

Junio C Hamano· Dec 5, 2006, 00:12 UTC · re: Sam Vilain · lore

Thanks.

Please CC people who are primarily working on the part of the system you are improving. In the case of git-svn that would be Eric Wong.

As I almost never touch git-svn myself, I'll queue these four changes in 'pu' while waiting Ack from Eric on them.

Eric Wong· Dec 5, 2006, 01:04 UTC · re: Junio C Hamano · lore

Junio C Hamano <junkio@cox.net> wrote:

Show 5 quoted lines

> Thanks.
> 
> Please CC people who are primarily working on the part of the
> system you are improving.  In the case of git-svn that would be
> Eric Wong.

Yes, CCs regarding git-svn would be much appreciated, thanks.

> As I almost never touch git-svn myself, I'll queue these four
> changes in 'pu' while waiting Ack from Eric on them.

Ack on what the patches do, but not as-is.

Please fix the coding style so that it's consistent with the rest of git-svn:

a) indentation is done with hard tabs b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"

Also, adding tests would be helpful in helping me maintain it (I'm not a regular svk user, so I don't want to break anything you've done down the line).

Thanks.

Junio C Hamano· Dec 5, 2006, 01:10 UTC · re: Eric Wong · lore

Eric Wong <normalperson@yhbt.net> writes:

Show 10 quoted lines

> Junio C Hamano <junkio@cox.net> wrote:
>> 
>> Please CC people who are primarily working on the part of the
>> system you are improving.  In the case of git-svn that would be
>> Eric Wong.
>
> Yes, CCs regarding git-svn would be much appreciated, thanks.
> ...
> Please fix the coding style so that it's consistent with the rest of
> git-svn:

Thanks Eric for your quick response.

Show 6 quoted lines

> a) indentation is done with hard tabs
> b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"
>
> Also, adding tests would be helpful in helping me maintain it (I'm not
> a regular svk user, so I don't want to break anything you've done down
> the line).

Another request from the maintainer is to Sign-off the patches.