Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too

From: Eric Wong <normalperson@yhbt.net>
Date: Dec 5, 2006, 01:04 UTC
Message-ID: <20061205010428.GA26687@soma>
In-Reply-To: <7v3b7vnqtv.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:

Show 5 quoted lines

> Thanks.
> 
> Please CC people who are primarily working on the part of the
> system you are improving.  In the case of git-svn that would be
> Eric Wong.

Yes, CCs regarding git-svn would be much appreciated, thanks.

> As I almost never touch git-svn myself, I'll queue these four
> changes in 'pu' while waiting Ack from Eric on them.

Ack on what the patches do, but not as-is.

Please fix the coding style so that it's consistent with the rest of git-svn:

a) indentation is done with hard tabs b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {"

Also, adding tests would be helpful in helping me maintain it (I'm not a regular svk user, so I don't want to break anything you've done down the line).

Thanks.