{"thread":{"id":"43381","subject":"Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too","startedAt":"2006-12-04T09:33:03Z","lastAt":"2006-12-05T01:10:50Z","messageCount":4,"participants":["Junio C Hamano","Sam Vilain","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"295488","messageId":"20061204235724.46FD7139B0C@magnus.utsl.gen.nz","threadId":"43381","inReplyTo":null,"subject":"[PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too","fromName":"Sam Vilain","fromEmail":"sam@vilain.net","sentAt":"2006-12-04T09:33:03Z","receivedAt":"2006-12-04T09:33:03Z","isPatch":true,"sender":{"key":"sam@vilain.net","avatar":"https://gravatar.com/avatar/8fc840ca854dbf6f7065b4335e3b934951c1dca3b11db688e95e471901f8f4a8?d=mp&s=160"},"body":"Allow an extra parameter to be passed to the libsvn_ls_fullurl\nfunction to collect and return the properties of the URL being listed.\n---\n git-svn.perl |    7 ++++---\n 1 files changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/git-svn.perl b/git-svn.perl\nindex 3891122..93cfcc4 100755\n--- a/git-svn.perl\n+++ b/git-svn.perl\n@@ -3321,18 +3321,19 @@ sub libsvn_commit_cb {\n \n sub libsvn_ls_fullurl {\n \tmy $fullurl = shift;\n+\tmy $want_props = shift;\n \tmy $ra = libsvn_connect($fullurl);\n-\tmy @ret;\n+\tmy (@ret, @props);\n \tmy $pool = SVN::Pool->new;\n \tmy $r = defined $_revision ? $_revision : $ra->get_latest_revnum;\n-\tmy ($dirent, undef, undef) = $ra->get_dir('', $r, $pool);\n+\tmy ($dirent, undef, $props) = $ra->get_dir('', $r, $pool);\n \tforeach my $d (keys %$dirent) {\n \t\tif ($dirent->{$d}->kind == $SVN::Node::dir) {\n \t\t\tpush @ret, \"$d/\"; # add '/' for compat with cli svn\n \t\t}\n \t}\n \t$pool->clear;\n-\treturn @ret;\n+\treturn ($want_props ? (\\@ret, $props) : @ret);\n }\n \n \n-- \n1.4.4.1.ge918e-dirty\n"},{"id":"294776","messageId":"7v3b7vnqtv.fsf@assigned-by-dhcp.cox.net","threadId":"43381","inReplyTo":"20061204235724.46FD7139B0C@magnus.utsl.gen.nz","subject":"Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-12-05T00:12:28Z","receivedAt":"2006-12-05T00:12:28Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n\nPlease CC people who are primarily working on the part of the\nsystem you are improving.  In the case of git-svn that would be\nEric Wong.\n\nAs I almost never touch git-svn myself, I'll queue these four\nchanges in 'pu' while waiting Ack from Eric on them.\n\n\n\n"},{"id":"298591","messageId":"20061205010428.GA26687@soma","threadId":"43381","inReplyTo":"7v3b7vnqtv.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2006-12-05T01:04:28Z","receivedAt":"2006-12-05T01:04:28Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano <junkio@cox.net> wrote:\n> Thanks.\n> \n> Please CC people who are primarily working on the part of the\n> system you are improving.  In the case of git-svn that would be\n> Eric Wong.\n\nYes, CCs regarding git-svn would be much appreciated, thanks.\n\n> As I almost never touch git-svn myself, I'll queue these four\n> changes in 'pu' while waiting Ack from Eric on them.\n\nAck on what the patches do, but not as-is.\n\nPlease fix the coding style so that it's consistent with the rest of\ngit-svn:\n\na) indentation is done with hard tabs\nb) no spaces around parentheses: \"if ($foo) {\" vs \"if ( $foo ) {\"\n\nAlso, adding tests would be helpful in helping me maintain it (I'm not\na regular svk user, so I don't want to break anything you've done down\nthe line).\n\nThanks.\n\n-- \n"},{"id":"294568","messageId":"7vhcwbkuzp.fsf@assigned-by-dhcp.cox.net","threadId":"43381","inReplyTo":"20061205010428.GA26687@soma","subject":"Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-12-05T01:10:50Z","receivedAt":"2006-12-05T01:10:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong <normalperson@yhbt.net> writes:\n\n> Junio C Hamano <junkio@cox.net> wrote:\n>> \n>> Please CC people who are primarily working on the part of the\n>> system you are improving.  In the case of git-svn that would be\n>> Eric Wong.\n>\n> Yes, CCs regarding git-svn would be much appreciated, thanks.\n> ...\n> Please fix the coding style so that it's consistent with the rest of\n> git-svn:\n\nThanks Eric for your quick response.\n\n> a) indentation is done with hard tabs\n> b) no spaces around parentheses: \"if ($foo) {\" vs \"if ( $foo ) {\"\n>\n> Also, adding tests would be helpful in helping me maintain it (I'm not\n> a regular svk user, so I don't want to break anything you've done down\n> the line).\n\nAnother request from the maintainer is to Sign-off the patches.\n"}]}