# Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too 4 messages from 2006-12-04 to 2006-12-05. Participants: Junio C Hamano, Sam Vilain, Eric Wong. Thread: https://gitlist.dev/t/43381 ## Sam Vilain, 2006-12-04 09:33 Subject: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too Message-ID: <20061204235724.46FD7139B0C@magnus.utsl.gen.nz> URL: https://gitlist.dev/e/20061204235724.46FD7139B0C%40magnus.utsl.gen.nz ``` Allow an extra parameter to be passed to the libsvn_ls_fullurl function to collect and return the properties of the URL being listed. --- git-svn.perl | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/git-svn.perl b/git-svn.perl index 3891122..93cfcc4 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -3321,18 +3321,19 @@ sub libsvn_commit_cb { sub libsvn_ls_fullurl { my $fullurl = shift; + my $want_props = shift; my $ra = libsvn_connect($fullurl); - my @ret; + my (@ret, @props); my $pool = SVN::Pool->new; my $r = defined $_revision ? $_revision : $ra->get_latest_revnum; - my ($dirent, undef, undef) = $ra->get_dir('', $r, $pool); + my ($dirent, undef, $props) = $ra->get_dir('', $r, $pool); foreach my $d (keys %$dirent) { if ($dirent->{$d}->kind == $SVN::Node::dir) { push @ret, "$d/"; # add '/' for compat with cli svn } } $pool->clear; - return @ret; + return ($want_props ? (\@ret, $props) : @ret); } -- 1.4.4.1.ge918e-dirty ``` ## Junio C Hamano, 2006-12-05 00:12 Subject: Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too Message-ID: <7v3b7vnqtv.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7v3b7vnqtv.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20061204235724.46FD7139B0C@magnus.utsl.gen.nz> ``` Thanks. Please CC people who are primarily working on the part of the system you are improving. In the case of git-svn that would be Eric Wong. As I almost never touch git-svn myself, I'll queue these four changes in 'pu' while waiting Ack from Eric on them. ``` ## Eric Wong, 2006-12-05 01:04 Subject: Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too Message-ID: <20061205010428.GA26687@soma> URL: https://gitlist.dev/e/20061205010428.GA26687%40soma In-Reply-To: <7v3b7vnqtv.fsf@assigned-by-dhcp.cox.net> ``` Junio C Hamano wrote: > Thanks. > > Please CC people who are primarily working on the part of the > system you are improving. In the case of git-svn that would be > Eric Wong. Yes, CCs regarding git-svn would be much appreciated, thanks. > As I almost never touch git-svn myself, I'll queue these four > changes in 'pu' while waiting Ack from Eric on them. Ack on what the patches do, but not as-is. Please fix the coding style so that it's consistent with the rest of git-svn: a) indentation is done with hard tabs b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {" Also, adding tests would be helpful in helping me maintain it (I'm not a regular svk user, so I don't want to break anything you've done down the line). Thanks. -- ``` ## Junio C Hamano, 2006-12-05 01:10 Subject: Re: [PATCH 1/4] git-svn: let libsvn_ls_fullurl return properties too Message-ID: <7vhcwbkuzp.fsf@assigned-by-dhcp.cox.net> URL: https://gitlist.dev/e/7vhcwbkuzp.fsf%40assigned-by-dhcp.cox.net In-Reply-To: <20061205010428.GA26687@soma> ``` Eric Wong writes: > Junio C Hamano wrote: >> >> Please CC people who are primarily working on the part of the >> system you are improving. In the case of git-svn that would be >> Eric Wong. > > Yes, CCs regarding git-svn would be much appreciated, thanks. > ... > Please fix the coding style so that it's consistent with the rest of > git-svn: Thanks Eric for your quick response. > a) indentation is done with hard tabs > b) no spaces around parentheses: "if ($foo) {" vs "if ( $foo ) {" > > Also, adding tests would be helpful in helping me maintain it (I'm not > a regular svk user, so I don't want to break anything you've done down > the line). Another request from the maintainer is to Sign-off the patches. ```