threads / patch / 43017

patchxdiffi.c: mark some file-local symbols as static

Subject: [PATCH] xdiffi.c: mark some file-local symbols as static

## tl;dr

2 messages between Aug 5, 2016 and Aug 11, 2016. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Aug 5, 2016, 20:57 UTC · lore
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Michael,

If you need to re-roll your 'mh/diff-indent-heuristic' branch, could you please squash this into the relevant patch (e199b6e2, "diff: improve positioning of add/delete blocks in diffs", 04-08-2016).

Thanks!

ATB, Ramsay Jones

 xdiff/xdiffi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to xdiff/xdiffi.c +2 −2
diff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c
index 80307f5..90226f8 100644
--- a/xdiff/xdiffi.c
+++ b/xdiff/xdiffi.c
@@ -499,7 +499,7 @@ struct split_measurement {
 /*
  * Fill m with information about a hypothetical split of xdf above line split.
  */
-void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)
+static void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)
 {
 	long i;
 
@@ -557,7 +557,7 @@ void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)
  * Also see that project if you want to improve the weights based on, for example,
  * a larger or more diverse corpus.
  */
-int score_split(const struct split_measurement *m)
+static int score_split(const struct split_measurement *m)
 {
 	/*
 	 * A place to accumulate bonus factors (positive makes this index more
-- 
2.9.0
Michael Haggerty· Aug 11, 2016, 08:52 UTC · re: Ramsay Jones · lore

Re: [PATCH] xdiffi.c: mark some file-local symbols as static

On 08/05/2016 10:57 PM, Ramsay Jones wrote:
> If you need to re-roll your 'mh/diff-indent-heuristic' branch, could
> you please squash this into the relevant patch (e199b6e2, "diff: improve
> positioning of add/delete blocks in diffs", 04-08-2016).
Will do. Thanks, Ramsay!
Michael

← back to recent threads