git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] xdiffi.c: mark some file-local symbols as static

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Aug 5, 2016, 20:57 UTC
Message-ID
<29c40cdd-363a-df09-f9e2-fe9070bb8a9c@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Michael,

If you need to re-roll your 'mh/diff-indent-heuristic' branch, could you please squash this into the relevant patch (e199b6e2, "diff: improve positioning of add/delete blocks in diffs", 04-08-2016).

Thanks!

ATB, Ramsay Jones

 xdiff/xdiffi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c
index 80307f5..90226f8 100644
--- a/xdiff/xdiffi.c
+++ b/xdiff/xdiffi.c
@@ -499,7 +499,7 @@ struct split_measurement {
 /*
  * Fill m with information about a hypothetical split of xdf above line split.
  */
-void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)
+static void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)
 {
 	long i;
 
@@ -557,7 +557,7 @@ void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)
  * Also see that project if you want to improve the weights based on, for example,
  * a larger or more diverse corpus.
  */
-int score_split(const struct split_measurement *m)
+static int score_split(const struct split_measurement *m)
 {
 	/*
 	 * A place to accumulate bonus factors (positive makes this index more
-- 
2.9.0
Next: Michael Haggerty
Message 1 of 2 in “xdiffi.c: mark some file-local symbols as static”
  1. xdiffi.c: mark some file-local symbols as staticRamsay Jones, Aug 5, 2016
  2. Michael HaggertyAug 11, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.