{"thread":{"id":"43017","subject":"[PATCH] xdiffi.c: mark some file-local symbols as static","startedAt":"2016-08-05T20:57:33Z","lastAt":"2016-08-11T08:52:44Z","messageCount":2,"participants":["Ramsay Jones","Michael Haggerty"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"293235","messageId":"29c40cdd-363a-df09-f9e2-fe9070bb8a9c@ramsayjones.plus.com","threadId":"43017","inReplyTo":null,"subject":"[PATCH] xdiffi.c: mark some file-local symbols as static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2016-08-05T20:57:13Z","receivedAt":"2016-08-05T20:57:33Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Michael,\n\nIf you need to re-roll your 'mh/diff-indent-heuristic' branch, could\nyou please squash this into the relevant patch (e199b6e2, \"diff: improve\npositioning of add/delete blocks in diffs\", 04-08-2016).\n\nThanks!\n\nATB,\nRamsay Jones\n\n xdiff/xdiffi.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c\nindex 80307f5..90226f8 100644\n--- a/xdiff/xdiffi.c\n+++ b/xdiff/xdiffi.c\n@@ -499,7 +499,7 @@ struct split_measurement {\n /*\n  * Fill m with information about a hypothetical split of xdf above line split.\n  */\n-void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)\n+static void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)\n {\n \tlong i;\n \n@@ -557,7 +557,7 @@ void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m)\n  * Also see that project if you want to improve the weights based on, for example,\n  * a larger or more diverse corpus.\n  */\n-int score_split(const struct split_measurement *m)\n+static int score_split(const struct split_measurement *m)\n {\n \t/*\n \t * A place to accumulate bonus factors (positive makes this index more\n-- \n2.9.0\n"},{"id":"293698","messageId":"3f39b220-d33e-97af-f43e-00a265c32fa6@alum.mit.edu","threadId":"43017","inReplyTo":"29c40cdd-363a-df09-f9e2-fe9070bb8a9c@ramsayjones.plus.com","subject":"Re: [PATCH] xdiffi.c: mark some file-local symbols as static","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2016-08-11T08:52:18Z","receivedAt":"2016-08-11T08:52:44Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"On 08/05/2016 10:57 PM, Ramsay Jones wrote:\n> If you need to re-roll your 'mh/diff-indent-heuristic' branch, could\n> you please squash this into the relevant patch (e199b6e2, \"diff: improve\n> positioning of add/delete blocks in diffs\", 04-08-2016).\n\nWill do. Thanks, Ramsay!\n\nMichael\n\n\n"}]}