# [PATCH] xdiffi.c: mark some file-local symbols as static 2 messages from 2016-08-05 to 2016-08-11. Participants: Ramsay Jones, Michael Haggerty. Thread: https://gitlist.dev/t/43017 ## Ramsay Jones, 2016-08-05 20:57 Subject: [PATCH] xdiffi.c: mark some file-local symbols as static Message-ID: <29c40cdd-363a-df09-f9e2-fe9070bb8a9c@ramsayjones.plus.com> URL: https://gitlist.dev/e/29c40cdd-363a-df09-f9e2-fe9070bb8a9c%40ramsayjones.plus.com ``` Signed-off-by: Ramsay Jones --- Hi Michael, If you need to re-roll your 'mh/diff-indent-heuristic' branch, could you please squash this into the relevant patch (e199b6e2, "diff: improve positioning of add/delete blocks in diffs", 04-08-2016). Thanks! ATB, Ramsay Jones xdiff/xdiffi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c index 80307f5..90226f8 100644 --- a/xdiff/xdiffi.c +++ b/xdiff/xdiffi.c @@ -499,7 +499,7 @@ struct split_measurement { /* * Fill m with information about a hypothetical split of xdf above line split. */ -void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m) +static void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m) { long i; @@ -557,7 +557,7 @@ void measure_split(const xdfile_t *xdf, long split, struct split_measurement *m) * Also see that project if you want to improve the weights based on, for example, * a larger or more diverse corpus. */ -int score_split(const struct split_measurement *m) +static int score_split(const struct split_measurement *m) { /* * A place to accumulate bonus factors (positive makes this index more -- 2.9.0 ``` ## Michael Haggerty, 2016-08-11 08:52 Subject: Re: [PATCH] xdiffi.c: mark some file-local symbols as static Message-ID: <3f39b220-d33e-97af-f43e-00a265c32fa6@alum.mit.edu> URL: https://gitlist.dev/e/3f39b220-d33e-97af-f43e-00a265c32fa6%40alum.mit.edu In-Reply-To: <29c40cdd-363a-df09-f9e2-fe9070bb8a9c@ramsayjones.plus.com> ``` On 08/05/2016 10:57 PM, Ramsay Jones wrote: > If you need to re-roll your 'mh/diff-indent-heuristic' branch, could > you please squash this into the relevant patch (e199b6e2, "diff: improve > positioning of add/delete blocks in diffs", 04-08-2016). Will do. Thanks, Ramsay! Michael ```