threads / patch / 42244

patcht: fix duplicate words of "output"

Subject: [PATCH] t: fix duplicate words of "output"

## tl;dr

3 messages between May 6, 2016 and May 7, 2016. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Li Peng· May 6, 2016, 12:22 UTC · lore

Fix duplicate words of "output" in comment.

Signed-off-by: Li Peng <lip@dtdream.com>
---
 t/t0000-basic.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to t/t0000-basic.sh +1 −1

diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 79b9074..60811a3 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -98,7 +98,7 @@ check_sub_test_lib_test () {
 }
 
 check_sub_test_lib_test_err () {
-	name="$1" # stdin is the expected output output from the test
+	name="$1" # stdin is the expected output from the test
 	# expected error output is in descriptior 3
 	(
 		cd "$name" &&

-- 
1.8.3.1

Junio C Hamano· May 6, 2016, 17:26 UTC · re: Li Peng · lore

Re: [PATCH] t: fix duplicate words of "output"

Li Peng <lip@dtdream.com> writes:

Show 17 quoted lines

> Fix duplicate words of "output" in comment.
>
> Signed-off-by: Li Peng <lip@dtdream.com>
> ---
>  t/t0000-basic.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index 79b9074..60811a3 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -98,7 +98,7 @@ check_sub_test_lib_test () {
>  }
>  
>  check_sub_test_lib_test_err () {
> -	name="$1" # stdin is the expected output output from the test
> +	name="$1" # stdin is the expected output from the test

The original is marginally correct. The first "output" is a noun, "expected output", the second one is a pp of verb "to output", i.e. "to produce".

I would have written it as "the expected output produced by the test", though.

Ilya Bobyr· May 7, 2016, 00:15 UTC · re: Junio C Hamano · lore

Re: [PATCH] t: fix duplicate words of "output"

On 5/6/2016 10:26 AM, Junio C Hamano wrote:

Show 25 quoted lines

> Li Peng <lip@dtdream.com> writes:
>
>> Fix duplicate words of "output" in comment.
>>
>> Signed-off-by: Li Peng <lip@dtdream.com>
>> ---
>>  t/t0000-basic.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
>> index 79b9074..60811a3 100755
>> --- a/t/t0000-basic.sh
>> +++ b/t/t0000-basic.sh
>> @@ -98,7 +98,7 @@ check_sub_test_lib_test () {
>>  }
>>  
>>  check_sub_test_lib_test_err () {
>> -	name="$1" # stdin is the expected output output from the test
>> +	name="$1" # stdin is the expected output from the test
> The original is marginally correct.  The first "output" is a noun,
> "expected output", the second one is a pp of verb "to output",
> i.e. "to produce".
>
> I would have written it as "the expected output produced by the
> test", though.

Right, the original form is quite hard to understand %)