Re: [PATCH] t: fix duplicate words of "output"

From: Ilya Bobyr <ilya.bobyr@gmail.com>
Date: May 7, 2016, 00:15 UTC
Message-ID: <d20429f9-993a-b348-3bbd-0577fbf4688d@gmail.com>
In-Reply-To: <xmqqshxv3xno.fsf@gitster.mtv.corp.google.com>

On 5/6/2016 10:26 AM, Junio C Hamano wrote:

Show 25 quoted lines

> Li Peng <lip@dtdream.com> writes:
>
>> Fix duplicate words of "output" in comment.
>>
>> Signed-off-by: Li Peng <lip@dtdream.com>
>> ---
>>  t/t0000-basic.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
>> index 79b9074..60811a3 100755
>> --- a/t/t0000-basic.sh
>> +++ b/t/t0000-basic.sh
>> @@ -98,7 +98,7 @@ check_sub_test_lib_test () {
>>  }
>>  
>>  check_sub_test_lib_test_err () {
>> -	name="$1" # stdin is the expected output output from the test
>> +	name="$1" # stdin is the expected output from the test
> The original is marginally correct.  The first "output" is a noun,
> "expected output", the second one is a pp of verb "to output",
> i.e. "to produce".
>
> I would have written it as "the expected output produced by the
> test", though.

Right, the original form is quite hard to understand %)