Re: [PATCH] t: fix duplicate words of "output"

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2016, 17:26 UTC
Message-ID: <xmqqshxv3xno.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1462537363-17962-1-git-send-email-lip@dtdream.com>

Li Peng <lip@dtdream.com> writes:

Show 17 quoted lines

> Fix duplicate words of "output" in comment.
>
> Signed-off-by: Li Peng <lip@dtdream.com>
> ---
>  t/t0000-basic.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
> index 79b9074..60811a3 100755
> --- a/t/t0000-basic.sh
> +++ b/t/t0000-basic.sh
> @@ -98,7 +98,7 @@ check_sub_test_lib_test () {
>  }
>  
>  check_sub_test_lib_test_err () {
> -	name="$1" # stdin is the expected output output from the test
> +	name="$1" # stdin is the expected output from the test

The original is marginally correct. The first "output" is a noun, "expected output", the second one is a pp of verb "to output", i.e. "to produce".

I would have written it as "the expected output produced by the test", though.