# [PATCH] t: fix duplicate words of "output" 3 messages from 2016-05-06 to 2016-05-07. Participants: Li Peng, Junio C Hamano, Ilya Bobyr. Thread: https://gitlist.dev/t/42244 ## Li Peng, 2016-05-06 12:22 Subject: [PATCH] t: fix duplicate words of "output" Message-ID: <1462537363-17962-1-git-send-email-lip@dtdream.com> URL: https://gitlist.dev/e/1462537363-17962-1-git-send-email-lip%40dtdream.com ``` Fix duplicate words of "output" in comment. Signed-off-by: Li Peng --- t/t0000-basic.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index 79b9074..60811a3 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -98,7 +98,7 @@ check_sub_test_lib_test () { } check_sub_test_lib_test_err () { - name="$1" # stdin is the expected output output from the test + name="$1" # stdin is the expected output from the test # expected error output is in descriptior 3 ( cd "$name" && -- 1.8.3.1 ``` ## Junio C Hamano, 2016-05-06 17:26 Subject: Re: [PATCH] t: fix duplicate words of "output" Message-ID: URL: https://gitlist.dev/e/xmqqshxv3xno.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1462537363-17962-1-git-send-email-lip@dtdream.com> ``` Li Peng writes: > Fix duplicate words of "output" in comment. > > Signed-off-by: Li Peng > --- > t/t0000-basic.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh > index 79b9074..60811a3 100755 > --- a/t/t0000-basic.sh > +++ b/t/t0000-basic.sh > @@ -98,7 +98,7 @@ check_sub_test_lib_test () { > } > > check_sub_test_lib_test_err () { > - name="$1" # stdin is the expected output output from the test > + name="$1" # stdin is the expected output from the test The original is marginally correct. The first "output" is a noun, "expected output", the second one is a pp of verb "to output", i.e. "to produce". I would have written it as "the expected output produced by the test", though. ``` ## Ilya Bobyr, 2016-05-07 00:15 Subject: Re: [PATCH] t: fix duplicate words of "output" Message-ID: URL: https://gitlist.dev/e/d20429f9-993a-b348-3bbd-0577fbf4688d%40gmail.com In-Reply-To: ``` On 5/6/2016 10:26 AM, Junio C Hamano wrote: > Li Peng writes: > >> Fix duplicate words of "output" in comment. >> >> Signed-off-by: Li Peng >> --- >> t/t0000-basic.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh >> index 79b9074..60811a3 100755 >> --- a/t/t0000-basic.sh >> +++ b/t/t0000-basic.sh >> @@ -98,7 +98,7 @@ check_sub_test_lib_test () { >> } >> >> check_sub_test_lib_test_err () { >> - name="$1" # stdin is the expected output output from the test >> + name="$1" # stdin is the expected output from the test > The original is marginally correct. The first "output" is a noun, > "expected output", the second one is a pp of verb "to output", > i.e. "to produce". > > I would have written it as "the expected output produced by the > test", though. Right, the original form is quite hard to understand %) ```