threads / patch / 41781

patch(exit 1) is silly

Subject: [PATCH] (exit 1) is silly

## tl;dr

4 messages between Mar 22, 2016 and Mar 22, 2016. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

izabera· Mar 22, 2016, 15:47 UTC · lore

Signed-off-by: izabera <izaberina@gmail.com>
---
 GIT-VERSION-GEN | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to GIT-VERSION-GEN +1 −1

diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
index b5072a2..17b6ef4 100755
--- a/GIT-VERSION-GEN
+++ b/GIT-VERSION-GEN
@@ -14,7 +14,7 @@ then
 elif test -d ${GIT_DIR:-.git} -o -f .git &&
 	VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
 	case "$VN" in
-	*$LF*) (exit 1) ;;
+	*$LF*) false ;;
 	v[0-9]*)
 		git update-index -q --refresh
 		test -z "$(git diff-index --name-only HEAD --)" ||

-- 
2.7.4

Junio C Hamano· Mar 22, 2016, 16:16 UTC · re: izabera · lore

Re: [PATCH] (exit 1) is silly

izabera <izaberina@gmail.com> writes:

Show 18 quoted lines

> Signed-off-by: izabera <izaberina@gmail.com>
> ---
>  GIT-VERSION-GEN | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index b5072a2..17b6ef4 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -14,7 +14,7 @@ then
>  elif test -d ${GIT_DIR:-.git} -o -f .git &&
>  	VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
>  	case "$VN" in
> -	*$LF*) (exit 1) ;;
> +	*$LF*) false ;;
>  	v[0-9]*)
>  		git update-index -q --refresh
>  		test -z "$(git diff-index --name-only HEAD --)" ||

IMO, this is such a minor thing that once it _is_ in the tree, it's not really worth the patch noise to go and fix it up.

Sebastian Schuberth· Mar 22, 2016, 17:08 UTC · re: Junio C Hamano · lore

Re: [PATCH] (exit 1) is silly

On 3/22/2016 17:16, Junio C Hamano wrote:

> IMO, this is such a minor thing that once it _is_ in the tree, it's
> not really worth the patch noise to go and fix it up.

IMO, instead of writing this you could have just accepted the patch, reducing the patch noise ;-)

Regards, Sebastian

Junio C Hamano· Mar 22, 2016, 17:45 UTC · re: Sebastian Schuberth · lore

Re: [PATCH] (exit 1) is silly

Sebastian Schuberth <sschuberth@gmail.com> writes:

Show 7 quoted lines

> On 3/22/2016 17:16, Junio C Hamano wrote:
>
>> IMO, this is such a minor thing that once it _is_ in the tree, it's
>> not really worth the patch noise to go and fix it up.
>
> IMO, instead of writing this you could have just accepted the patch,
> reducing the patch noise ;-)

"patch noise" does not mean the volume of the list traffic. It is the number of pointless changes in the history of the project, and accepting this patch would _encourage_ similar pointless changes, i.e. "patch noise".