Re: [PATCH] (exit 1) is silly

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 22, 2016, 16:16 UTC
Message-ID: <xmqq8u1ajxnk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1458661671-3793-1-git-send-email-izaberina@gmail.com>

izabera <izaberina@gmail.com> writes:

Show 18 quoted lines

> Signed-off-by: izabera <izaberina@gmail.com>
> ---
>  GIT-VERSION-GEN | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN
> index b5072a2..17b6ef4 100755
> --- a/GIT-VERSION-GEN
> +++ b/GIT-VERSION-GEN
> @@ -14,7 +14,7 @@ then
>  elif test -d ${GIT_DIR:-.git} -o -f .git &&
>  	VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) &&
>  	case "$VN" in
> -	*$LF*) (exit 1) ;;
> +	*$LF*) false ;;
>  	v[0-9]*)
>  		git update-index -q --refresh
>  		test -z "$(git diff-index --name-only HEAD --)" ||

IMO, this is such a minor thing that once it _is_ in the tree, it's not really worth the patch noise to go and fix it up.