{"thread":{"id":"41781","subject":"[PATCH] (exit 1) is silly","startedAt":"2016-03-22T15:47:51Z","lastAt":"2016-03-22T17:45:54Z","messageCount":4,"participants":["izabera","Junio C Hamano","Sebastian Schuberth"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"281433","messageId":"1458661671-3793-1-git-send-email-izaberina@gmail.com","threadId":"41781","inReplyTo":null,"subject":"[PATCH] (exit 1) is silly","fromName":"izabera","fromEmail":"izaberina@gmail.com","sentAt":"2016-03-22T15:47:51Z","receivedAt":"2016-03-22T15:47:51Z","isPatch":true,"sender":{"key":"izaberina@gmail.com","avatar":null},"body":"Signed-off-by: izabera <izaberina@gmail.com>\n---\n GIT-VERSION-GEN | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN\nindex b5072a2..17b6ef4 100755\n--- a/GIT-VERSION-GEN\n+++ b/GIT-VERSION-GEN\n@@ -14,7 +14,7 @@ then\n elif test -d ${GIT_DIR:-.git} -o -f .git &&\n \tVN=$(git describe --match \"v[0-9]*\" --abbrev=7 HEAD 2>/dev/null) &&\n \tcase \"$VN\" in\n-\t*$LF*) (exit 1) ;;\n+\t*$LF*) false ;;\n \tv[0-9]*)\n \t\tgit update-index -q --refresh\n \t\ttest -z \"$(git diff-index --name-only HEAD --)\" ||\n-- \n2.7.4\n"},{"id":"281437","messageId":"xmqq8u1ajxnk.fsf@gitster.mtv.corp.google.com","threadId":"41781","inReplyTo":"1458661671-3793-1-git-send-email-izaberina@gmail.com","subject":"Re: [PATCH] (exit 1) is silly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-22T16:16:31Z","receivedAt":"2016-03-22T16:16:31Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"izabera <izaberina@gmail.com> writes:\n\n> Signed-off-by: izabera <izaberina@gmail.com>\n> ---\n>  GIT-VERSION-GEN | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN\n> index b5072a2..17b6ef4 100755\n> --- a/GIT-VERSION-GEN\n> +++ b/GIT-VERSION-GEN\n> @@ -14,7 +14,7 @@ then\n>  elif test -d ${GIT_DIR:-.git} -o -f .git &&\n>  \tVN=$(git describe --match \"v[0-9]*\" --abbrev=7 HEAD 2>/dev/null) &&\n>  \tcase \"$VN\" in\n> -\t*$LF*) (exit 1) ;;\n> +\t*$LF*) false ;;\n>  \tv[0-9]*)\n>  \t\tgit update-index -q --refresh\n>  \t\ttest -z \"$(git diff-index --name-only HEAD --)\" ||\n\nIMO, this is such a minor thing that once it _is_ in the tree, it's\nnot really worth the patch noise to go and fix it up.\n"},{"id":"281442","messageId":"56F17BFD.80606@gmail.com","threadId":"41781","inReplyTo":"xmqq8u1ajxnk.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] (exit 1) is silly","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2016-03-22T17:08:13Z","receivedAt":"2016-03-22T17:08:13Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On 3/22/2016 17:16, Junio C Hamano wrote:\n\n> IMO, this is such a minor thing that once it _is_ in the tree, it's\n> not really worth the patch noise to go and fix it up.\n\nIMO, instead of writing this you could have just accepted the patch, \nreducing the patch noise ;-)\n\nRegards,\nSebastian\n"},{"id":"281453","messageId":"xmqqk2kuiey5.fsf@gitster.mtv.corp.google.com","threadId":"41781","inReplyTo":"56F17BFD.80606@gmail.com","subject":"Re: [PATCH] (exit 1) is silly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-03-22T17:45:54Z","receivedAt":"2016-03-22T17:45:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Sebastian Schuberth <sschuberth@gmail.com> writes:\n\n> On 3/22/2016 17:16, Junio C Hamano wrote:\n>\n>> IMO, this is such a minor thing that once it _is_ in the tree, it's\n>> not really worth the patch noise to go and fix it up.\n>\n> IMO, instead of writing this you could have just accepted the patch,\n> reducing the patch noise ;-)\n\n\"patch noise\" does not mean the volume of the list traffic.  It is\nthe number of pointless changes in the history of the project, and\naccepting this patch would _encourage_ similar pointless changes,\ni.e. \"patch noise\".\n"}]}