# [PATCH] (exit 1) is silly 4 messages from 2016-03-22 to 2016-03-22. Participants: izabera, Junio C Hamano, Sebastian Schuberth. Thread: https://gitlist.dev/t/41781 ## izabera, 2016-03-22 15:47 Subject: [PATCH] (exit 1) is silly Message-ID: <1458661671-3793-1-git-send-email-izaberina@gmail.com> URL: https://gitlist.dev/e/1458661671-3793-1-git-send-email-izaberina%40gmail.com ``` Signed-off-by: izabera --- GIT-VERSION-GEN | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index b5072a2..17b6ef4 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -14,7 +14,7 @@ then elif test -d ${GIT_DIR:-.git} -o -f .git && VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) && case "$VN" in - *$LF*) (exit 1) ;; + *$LF*) false ;; v[0-9]*) git update-index -q --refresh test -z "$(git diff-index --name-only HEAD --)" || -- 2.7.4 ``` ## Junio C Hamano, 2016-03-22 16:16 Subject: Re: [PATCH] (exit 1) is silly Message-ID: URL: https://gitlist.dev/e/xmqq8u1ajxnk.fsf%40gitster.mtv.corp.google.com In-Reply-To: <1458661671-3793-1-git-send-email-izaberina@gmail.com> ``` izabera writes: > Signed-off-by: izabera > --- > GIT-VERSION-GEN | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN > index b5072a2..17b6ef4 100755 > --- a/GIT-VERSION-GEN > +++ b/GIT-VERSION-GEN > @@ -14,7 +14,7 @@ then > elif test -d ${GIT_DIR:-.git} -o -f .git && > VN=$(git describe --match "v[0-9]*" --abbrev=7 HEAD 2>/dev/null) && > case "$VN" in > - *$LF*) (exit 1) ;; > + *$LF*) false ;; > v[0-9]*) > git update-index -q --refresh > test -z "$(git diff-index --name-only HEAD --)" || IMO, this is such a minor thing that once it _is_ in the tree, it's not really worth the patch noise to go and fix it up. ``` ## Sebastian Schuberth, 2016-03-22 17:08 Subject: Re: [PATCH] (exit 1) is silly Message-ID: <56F17BFD.80606@gmail.com> URL: https://gitlist.dev/e/56F17BFD.80606%40gmail.com In-Reply-To: ``` On 3/22/2016 17:16, Junio C Hamano wrote: > IMO, this is such a minor thing that once it _is_ in the tree, it's > not really worth the patch noise to go and fix it up. IMO, instead of writing this you could have just accepted the patch, reducing the patch noise ;-) Regards, Sebastian ``` ## Junio C Hamano, 2016-03-22 17:45 Subject: Re: [PATCH] (exit 1) is silly Message-ID: URL: https://gitlist.dev/e/xmqqk2kuiey5.fsf%40gitster.mtv.corp.google.com In-Reply-To: <56F17BFD.80606@gmail.com> ``` Sebastian Schuberth writes: > On 3/22/2016 17:16, Junio C Hamano wrote: > >> IMO, this is such a minor thing that once it _is_ in the tree, it's >> not really worth the patch noise to go and fix it up. > > IMO, instead of writing this you could have just accepted the patch, > reducing the patch noise ;-) "patch noise" does not mean the volume of the list traffic. It is the number of pointless changes in the history of the project, and accepting this patch would _encourage_ similar pointless changes, i.e. "patch noise". ```