threads / patch / 40971

patchcompletion: remove 'git column' from porcelain commands

Subject: [PATCH] completion: remove 'git column' from porcelain commands

## tl;dr

3 messages between Dec 11, 2015 and Dec 11, 2015. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

SZEDER Gábor· Dec 11, 2015, 12:05 UTC · lore

'git column' is an internal helper, so it should not be offered on 'git <TAB>' along with porcelain commands.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash | 1 +
 1 file changed, 1 insertion(+)
Show changes to contrib/completion/git-completion.bash +1 −0
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 111b05302b..5dec8778f7 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
 		check-mailmap)    : plumbing;;
 		check-ref-format) : plumbing;;
 		checkout-index)   : plumbing;;
+		column)           : internal helper;;
 		commit-tree)      : plumbing;;
 		count-objects)    : infrequent;;
 		credential)       : credentials;;

-- 
2.6.3.420.g7bbb372
Junio C Hamano· Dec 11, 2015, 18:16 UTC · re: SZEDER Gábor · lore

Re: [PATCH] completion: remove 'git column' from porcelain commands

SZEDER Gábor <szeder@ira.uka.de> writes:
Show 5 quoted lines
> 'git column' is an internal helper, so it should not be offered on
> 'git <TAB>' along with porcelain commands.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---

I think this makes sense. Objections?

Show 15 quoted lines
>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 111b05302b..5dec8778f7 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
>  		check-mailmap)    : plumbing;;
>  		check-ref-format) : plumbing;;
>  		checkout-index)   : plumbing;;
> +		column)           : internal helper;;
>  		commit-tree)      : plumbing;;
>  		count-objects)    : infrequent;;
>  		credential)       : credentials;;
Duy Nguyen· Dec 11, 2015, 18:21 UTC · re: Junio C Hamano · lore

Re: [PATCH] completion: remove 'git column' from porcelain commands

On Fri, Dec 11, 2015 at 7:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> 'git column' is an internal helper, so it should not be offered on
>> 'git <TAB>' along with porcelain commands.
>>
>> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>> ---
>
> I think this makes sense.
> Objections?
Not from me.
-- 
Duy

← back to recent threads