{"thread":{"id":"40971","subject":"[PATCH] completion: remove 'git column' from porcelain commands","startedAt":"2015-12-11T12:05:00Z","lastAt":"2015-12-11T18:21:51Z","messageCount":3,"participants":["SZEDER Gábor","Junio C Hamano","Duy Nguyen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"274270","messageId":"1449835500-24844-1-git-send-email-szeder@ira.uka.de","threadId":"40971","inReplyTo":null,"subject":"[PATCH] completion: remove 'git column' from porcelain commands","fromName":"SZEDER Gábor","fromEmail":"szeder@ira.uka.de","sentAt":"2015-12-11T12:05:00Z","receivedAt":"2015-12-11T12:05:00Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"'git column' is an internal helper, so it should not be offered on\n'git <TAB>' along with porcelain commands.\n\nSigned-off-by: SZEDER Gábor <szeder@ira.uka.de>\n---\n contrib/completion/git-completion.bash | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 111b05302b..5dec8778f7 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -664,6 +664,7 @@ __git_list_porcelain_commands ()\n \t\tcheck-mailmap)    : plumbing;;\n \t\tcheck-ref-format) : plumbing;;\n \t\tcheckout-index)   : plumbing;;\n+\t\tcolumn)           : internal helper;;\n \t\tcommit-tree)      : plumbing;;\n \t\tcount-objects)    : infrequent;;\n \t\tcredential)       : credentials;;\n-- \n2.6.3.420.g7bbb372\n"},{"id":"274280","messageId":"xmqqegesg8b2.fsf@gitster.mtv.corp.google.com","threadId":"40971","inReplyTo":"1449835500-24844-1-git-send-email-szeder@ira.uka.de","subject":"Re: [PATCH] completion: remove 'git column' from porcelain commands","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2015-12-11T18:16:17Z","receivedAt":"2015-12-11T18:16:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"SZEDER Gábor <szeder@ira.uka.de> writes:\n\n> 'git column' is an internal helper, so it should not be offered on\n> 'git <TAB>' along with porcelain commands.\n>\n> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>\n> ---\n\nI think this makes sense.\nObjections?\n\n>  contrib/completion/git-completion.bash | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 111b05302b..5dec8778f7 100644\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -664,6 +664,7 @@ __git_list_porcelain_commands ()\n>  \t\tcheck-mailmap)    : plumbing;;\n>  \t\tcheck-ref-format) : plumbing;;\n>  \t\tcheckout-index)   : plumbing;;\n> +\t\tcolumn)           : internal helper;;\n>  \t\tcommit-tree)      : plumbing;;\n>  \t\tcount-objects)    : infrequent;;\n>  \t\tcredential)       : credentials;;\n"},{"id":"274281","messageId":"CACsJy8BProX93z3O1=fEOeehVNCgkSh4yukn78Yxija1EgttQw@mail.gmail.com","threadId":"40971","inReplyTo":"xmqqegesg8b2.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] completion: remove 'git column' from porcelain commands","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2015-12-11T18:21:51Z","receivedAt":"2015-12-11T18:21:51Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Fri, Dec 11, 2015 at 7:16 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> SZEDER Gábor <szeder@ira.uka.de> writes:\n>\n>> 'git column' is an internal helper, so it should not be offered on\n>> 'git <TAB>' along with porcelain commands.\n>>\n>> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>\n>> ---\n>\n> I think this makes sense.\n> Objections?\n\nNot from me.\n-- \nDuy\n"}]}