# [PATCH] completion: remove 'git column' from porcelain commands

3 messages from 2015-12-11 to 2015-12-11. Participants: SZEDER Gábor, Junio C Hamano, Duy Nguyen.
Thread: https://gitlist.dev/t/40971

## SZEDER Gábor, 2015-12-11 12:05

Subject: [PATCH] completion: remove 'git column' from porcelain commands
Message-ID: <1449835500-24844-1-git-send-email-szeder@ira.uka.de>
URL: https://gitlist.dev/e/1449835500-24844-1-git-send-email-szeder%40ira.uka.de

```
'git column' is an internal helper, so it should not be offered on
'git <TAB>' along with porcelain commands.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
---
 contrib/completion/git-completion.bash | 1 +
 1 file changed, 1 insertion(+)

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 111b05302b..5dec8778f7 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
 		check-mailmap)    : plumbing;;
 		check-ref-format) : plumbing;;
 		checkout-index)   : plumbing;;
+		column)           : internal helper;;
 		commit-tree)      : plumbing;;
 		count-objects)    : infrequent;;
 		credential)       : credentials;;
-- 
2.6.3.420.g7bbb372

```

## Junio C Hamano, 2015-12-11 18:16

Subject: Re: [PATCH] completion: remove 'git column' from porcelain commands
Message-ID: <xmqqegesg8b2.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqegesg8b2.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <1449835500-24844-1-git-send-email-szeder@ira.uka.de>

```
SZEDER Gábor <szeder@ira.uka.de> writes:

> 'git column' is an internal helper, so it should not be offered on
> 'git <TAB>' along with porcelain commands.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---

I think this makes sense.
Objections?

>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 111b05302b..5dec8778f7 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
>  		check-mailmap)    : plumbing;;
>  		check-ref-format) : plumbing;;
>  		checkout-index)   : plumbing;;
> +		column)           : internal helper;;
>  		commit-tree)      : plumbing;;
>  		count-objects)    : infrequent;;
>  		credential)       : credentials;;

```

## Duy Nguyen, 2015-12-11 18:21

Subject: Re: [PATCH] completion: remove 'git column' from porcelain commands
Message-ID: <CACsJy8BProX93z3O1=fEOeehVNCgkSh4yukn78Yxija1EgttQw@mail.gmail.com>
URL: https://gitlist.dev/e/CACsJy8BProX93z3O1%3DfEOeehVNCgkSh4yukn78Yxija1EgttQw%40mail.gmail.com
In-Reply-To: <xmqqegesg8b2.fsf@gitster.mtv.corp.google.com>

```
On Fri, Dec 11, 2015 at 7:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
> SZEDER Gábor <szeder@ira.uka.de> writes:
>
>> 'git column' is an internal helper, so it should not be offered on
>> 'git <TAB>' along with porcelain commands.
>>
>> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>> ---
>
> I think this makes sense.
> Objections?

Not from me.
-- 
Duy

```