Re: [PATCH] completion: remove 'git column' from porcelain commands

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2015, 18:16 UTC
Message-ID: <xmqqegesg8b2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1449835500-24844-1-git-send-email-szeder@ira.uka.de>

SZEDER Gábor <szeder@ira.uka.de> writes:

Show 5 quoted lines

> 'git column' is an internal helper, so it should not be offered on
> 'git <TAB>' along with porcelain commands.
>
> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
> ---

I think this makes sense. Objections?

Show 15 quoted lines

>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 111b05302b..5dec8778f7 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -664,6 +664,7 @@ __git_list_porcelain_commands ()
>  		check-mailmap)    : plumbing;;
>  		check-ref-format) : plumbing;;
>  		checkout-index)   : plumbing;;
> +		column)           : internal helper;;
>  		commit-tree)      : plumbing;;
>  		count-objects)    : infrequent;;
>  		credential)       : credentials;;