threads / patch / 39372

patchhelp.c: mark a file-local function static

Subject: [PATCH] help.c: mark a file-local function static

## tl;dr

2 messages between May 19, 2015 and May 19, 2015. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· May 19, 2015, 19:15 UTC · lore

Commit 4f671d74 ("help: respect new common command grouping", 18-05-2015) adds the 'cmd_group_cmp' funtion as an external symbol.

Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it be static?")

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Sebastien,

If you need to re-roll the patches in your 'sg/help-group' branch, could you please squash this into the relevant patch (commit 4f671d74).

Thanks!

ATB, Ramsay Jones

 help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to help.c +1 −1
diff --git a/help.c b/help.c
index 71027b7..7881ab7 100644
--- a/help.c
+++ b/help.c
@@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
 	}
 }
 
-int cmd_group_cmp(const void *elem1, const void *elem2)
+static int cmd_group_cmp(const void *elem1, const void *elem2)
 {
 	const struct cmdname_help *e1 = elem1;
 	const struct cmdname_help *e2 = elem2;
-- 
2.4.0
Sébastien Guimmara· May 19, 2015, 19:17 UTC · re: Ramsay Jones · lore

Re: [PATCH] help.c: mark a file-local function static

Hi Ramsay,
thanks for pointing that out, will squash it.
Sébastien
On 05/19/2015 09:15 PM, Ramsay Jones wrote:
Show 38 quoted lines
>
> Commit 4f671d74 ("help: respect new common command grouping",
> 18-05-2015) adds the 'cmd_group_cmp' funtion as an external
> symbol.
>
> Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it
> be static?")
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Sebastien,
>
> If you need to re-roll the patches in your 'sg/help-group' branch,
> could you please squash this into the relevant patch (commit 4f671d74).
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>   help.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/help.c b/help.c
> index 71027b7..7881ab7 100644
> --- a/help.c
> +++ b/help.c
> @@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
>   	}
>   }
>
> -int cmd_group_cmp(const void *elem1, const void *elem2)
> +static int cmd_group_cmp(const void *elem1, const void *elem2)
>   {
>   	const struct cmdname_help *e1 = elem1;
>   	const struct cmdname_help *e2 = elem2;
>

← back to recent threads