git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] help.c: mark a file-local function static

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
May 19, 2015, 19:15 UTC
Message-ID
<555B8BEB.1050103@ramsay1.demon.co.uk>

Commit 4f671d74 ("help: respect new common command grouping", 18-05-2015) adds the 'cmd_group_cmp' funtion as an external symbol.

Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it be static?")

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Sebastien,

If you need to re-roll the patches in your 'sg/help-group' branch, could you please squash this into the relevant patch (commit 4f671d74).

Thanks!

ATB, Ramsay Jones

 help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/help.c b/help.c
index 71027b7..7881ab7 100644
--- a/help.c
+++ b/help.c
@@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
 	}
 }
 
-int cmd_group_cmp(const void *elem1, const void *elem2)
+static int cmd_group_cmp(const void *elem1, const void *elem2)
 {
 	const struct cmdname_help *e1 = elem1;
 	const struct cmdname_help *e2 = elem2;
-- 
2.4.0
Next: Sébastien Guimmara
Message 1 of 2 in “help.c: mark a file-local function static”
  1. help.c: mark a file-local function staticRamsay Jones, May 19, 2015
  2. Sébastien GuimmaraMay 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.