{"thread":{"id":"39372","subject":"[PATCH] help.c: mark a file-local function static","startedAt":"2015-05-19T19:15:55Z","lastAt":"2015-05-19T19:17:55Z","messageCount":2,"participants":["Ramsay Jones","Sébastien Guimmara"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"261581","messageId":"555B8BEB.1050103@ramsay1.demon.co.uk","threadId":"39372","inReplyTo":null,"subject":"[PATCH] help.c: mark a file-local function static","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2015-05-19T19:15:55Z","receivedAt":"2015-05-19T19:15:55Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 4f671d74 (\"help: respect new common command grouping\",\n18-05-2015) adds the 'cmd_group_cmp' funtion as an external\nsymbol.\n\nNoticed by sparse. (\"'cmd_group_cmp' was not declared. Should it\nbe static?\")\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Sebastien,\n\nIf you need to re-roll the patches in your 'sg/help-group' branch,\ncould you please squash this into the relevant patch (commit 4f671d74).\n\nThanks!\n\nATB,\nRamsay Jones\n\n help.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/help.c b/help.c\nindex 71027b7..7881ab7 100644\n--- a/help.c\n+++ b/help.c\n@@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,\n \t}\n }\n \n-int cmd_group_cmp(const void *elem1, const void *elem2)\n+static int cmd_group_cmp(const void *elem1, const void *elem2)\n {\n \tconst struct cmdname_help *e1 = elem1;\n \tconst struct cmdname_help *e2 = elem2;\n-- \n2.4.0\n"},{"id":"261583","messageId":"555B8C63.8020606@gmail.com","threadId":"39372","inReplyTo":"555B8BEB.1050103@ramsay1.demon.co.uk","subject":"Re: [PATCH] help.c: mark a file-local function static","fromName":"Sébastien Guimmara","fromEmail":"sebastien.guimmara@gmail.com","sentAt":"2015-05-19T19:17:55Z","receivedAt":"2015-05-19T19:17:55Z","isPatch":true,"sender":{"key":"sebastien.guimmara@gmail.com","avatar":"https://gravatar.com/avatar/05d0b6a53712c5ed78d640976986949a3bda22c0dbf5ff13cabdd12c3f4094d6?d=mp&s=160"},"body":"Hi Ramsay,\n\nthanks for pointing that out, will squash it.\n\nSébastien\n\nOn 05/19/2015 09:15 PM, Ramsay Jones wrote:\n>\n> Commit 4f671d74 (\"help: respect new common command grouping\",\n> 18-05-2015) adds the 'cmd_group_cmp' funtion as an external\n> symbol.\n>\n> Noticed by sparse. (\"'cmd_group_cmp' was not declared. Should it\n> be static?\")\n>\n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n>\n> Hi Sebastien,\n>\n> If you need to re-roll the patches in your 'sg/help-group' branch,\n> could you please squash this into the relevant patch (commit 4f671d74).\n>\n> Thanks!\n>\n> ATB,\n> Ramsay Jones\n>\n>   help.c | 2 +-\n>   1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/help.c b/help.c\n> index 71027b7..7881ab7 100644\n> --- a/help.c\n> +++ b/help.c\n> @@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,\n>   \t}\n>   }\n>\n> -int cmd_group_cmp(const void *elem1, const void *elem2)\n> +static int cmd_group_cmp(const void *elem1, const void *elem2)\n>   {\n>   \tconst struct cmdname_help *e1 = elem1;\n>   \tconst struct cmdname_help *e2 = elem2;\n>\n"}]}