# [PATCH] help.c: mark a file-local function static

2 messages from 2015-05-19 to 2015-05-19. Participants: Ramsay Jones, Sébastien Guimmara.
Thread: https://gitlist.dev/t/39372

## Ramsay Jones, 2015-05-19 19:15

Subject: [PATCH] help.c: mark a file-local function static
Message-ID: <555B8BEB.1050103@ramsay1.demon.co.uk>
URL: https://gitlist.dev/e/555B8BEB.1050103%40ramsay1.demon.co.uk

```

Commit 4f671d74 ("help: respect new common command grouping",
18-05-2015) adds the 'cmd_group_cmp' funtion as an external
symbol.

Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it
be static?")

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Sebastien,

If you need to re-roll the patches in your 'sg/help-group' branch,
could you please squash this into the relevant patch (commit 4f671d74).

Thanks!

ATB,
Ramsay Jones

 help.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/help.c b/help.c
index 71027b7..7881ab7 100644
--- a/help.c
+++ b/help.c
@@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
 	}
 }
 
-int cmd_group_cmp(const void *elem1, const void *elem2)
+static int cmd_group_cmp(const void *elem1, const void *elem2)
 {
 	const struct cmdname_help *e1 = elem1;
 	const struct cmdname_help *e2 = elem2;
-- 
2.4.0

```

## Sébastien Guimmara, 2015-05-19 19:17

Subject: Re: [PATCH] help.c: mark a file-local function static
Message-ID: <555B8C63.8020606@gmail.com>
URL: https://gitlist.dev/e/555B8C63.8020606%40gmail.com
In-Reply-To: <555B8BEB.1050103@ramsay1.demon.co.uk>

```
Hi Ramsay,

thanks for pointing that out, will squash it.

Sébastien

On 05/19/2015 09:15 PM, Ramsay Jones wrote:
>
> Commit 4f671d74 ("help: respect new common command grouping",
> 18-05-2015) adds the 'cmd_group_cmp' funtion as an external
> symbol.
>
> Noticed by sparse. ("'cmd_group_cmp' was not declared. Should it
> be static?")
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Sebastien,
>
> If you need to re-roll the patches in your 'sg/help-group' branch,
> could you please squash this into the relevant patch (commit 4f671d74).
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
>   help.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/help.c b/help.c
> index 71027b7..7881ab7 100644
> --- a/help.c
> +++ b/help.c
> @@ -218,7 +218,7 @@ void list_commands(unsigned int colopts,
>   	}
>   }
>
> -int cmd_group_cmp(const void *elem1, const void *elem2)
> +static int cmd_group_cmp(const void *elem1, const void *elem2)
>   {
>   	const struct cmdname_help *e1 = elem1;
>   	const struct cmdname_help *e2 = elem2;
>

```