[PATCH] git-svn: propset support v2

Alfred Perlstein· Dec 6, 2014, 22:29 UTC · lore

I have incorporated Eric Wong's feedback into the git-svn propset support patch.

Issues resolved:
1) Test-case written.
2) Remove dead code.
3) Use shorter vars for formatting.
4) Fix bool comparisons.
5) Check for filesystem errors on write to .gitattribute file.
6) Use command_output_pipe() instead of open my $fh, '-|', ...
7) Refactor check for existing props.

There is a nit that I want to point out. The code does not support adding props unless there are also content changes to the files as well. You can see this in the testcase.

That is still sufficient for many people's workflows (FreeBSD at least). So I am wondering if this is OK.

I would gladly take any pointers to making it work with unchanged files either for a later diff or to wrap this up.

Thank you.

Alfred Perlstein (1):
  git-svn: Support for git-svn propset

 git-svn.perl               | 49 +++++++++++++++++++++++++++++++-
 perl/Git/SVN/Editor.pm     | 43 ++++++++++++++++++++++++++++
 t/t9148-git-svn-propset.sh | 71 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 162 insertions(+), 1 deletion(-)
 create mode 100755 t/t9148-git-svn-propset.sh

-- 
2.1.2

Eric Sunshine· Dec 7, 2014, 09:25 UTC · re: Alfred Perlstein · lore

Re: [PATCH] git-svn: propset support v2

On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein <alfred@freebsd.org> wrote:

Show 5 quoted lines

> I have incorporated Eric Wong's feedback into the git-svn propset support patch.
>
> There is a nit that I want to point out.  The code does not support adding props
> unless there are also content changes to the files as well.  You can see this in
> the testcase.

This is an important nugget of information which would be worthwhile to mention in the commit message of the patch rather than here as mere commentary.

Show 5 quoted lines

> That is still sufficient for many people's workflows (FreeBSD at
> least).  So I am wondering if this is OK.
>
> I would gladly take any pointers to making it work with unchanged
> files either for a later diff or to wrap this up.

patchgit-svn: propset support v2