git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-svn: propset support v2

From
Alfred Perlstein <alfred@freebsd.org>
Date
Dec 6, 2014, 22:29 UTC
Message-ID
<20141206222918.GA91825@elvis.mu.org>
I have incorporated Eric Wong's feedback into the git-svn propset support patch.
Issues resolved:
1) Test-case written.
2) Remove dead code.
3) Use shorter vars for formatting.
4) Fix bool comparisons.
5) Check for filesystem errors on write to .gitattribute file.
6) Use command_output_pipe() instead of open my $fh, '-|', ...
7) Refactor check for existing props.

There is a nit that I want to point out. The code does not support adding props unless there are also content changes to the files as well. You can see this in the testcase.

That is still sufficient for many people's workflows (FreeBSD at least). So I am wondering if this is OK.

I would gladly take any pointers to making it work with unchanged files either for a later diff or to wrap this up.

Thank you.
Alfred Perlstein (1):
  git-svn: Support for git-svn propset
 git-svn.perl               | 49 +++++++++++++++++++++++++++++++-
 perl/Git/SVN/Editor.pm     | 43 ++++++++++++++++++++++++++++
 t/t9148-git-svn-propset.sh | 71 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 162 insertions(+), 1 deletion(-)
 create mode 100755 t/t9148-git-svn-propset.sh
-- 
2.1.2
Next: Eric Sunshine
Message 1 of 2 in “git-svn: propset support v2”
  1. git-svn: propset support v2Alfred Perlstein, Dec 6, 2014
  2. Eric SunshineDec 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.