# [PATCH] git-svn: propset support v2

2 messages from 2014-12-06 to 2014-12-07. Participants: Alfred Perlstein, Eric Sunshine.
Thread: https://gitlist.dev/t/38133

## Alfred Perlstein, 2014-12-06 22:29

Subject: [PATCH] git-svn: propset support v2
Message-ID: <20141206222918.GA91825@elvis.mu.org>
URL: https://gitlist.dev/e/20141206222918.GA91825%40elvis.mu.org

```
I have incorporated Eric Wong's feedback into the git-svn propset support patch.

Issues resolved:
1) Test-case written.
2) Remove dead code.
3) Use shorter vars for formatting.
4) Fix bool comparisons.
5) Check for filesystem errors on write to .gitattribute file.
6) Use command_output_pipe() instead of open my $fh, '-|', ...
7) Refactor check for existing props.

There is a nit that I want to point out.  The code does not support adding props
unless there are also content changes to the files as well.  You can see this in
the testcase.

That is still sufficient for many people's workflows (FreeBSD at
least).  So I am wondering if this is OK. 

I would gladly take any pointers to making it work with unchanged
files either for a later diff or to wrap this up.

Thank you.

Alfred Perlstein (1):
  git-svn: Support for git-svn propset

 git-svn.perl               | 49 +++++++++++++++++++++++++++++++-
 perl/Git/SVN/Editor.pm     | 43 ++++++++++++++++++++++++++++
 t/t9148-git-svn-propset.sh | 71 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 162 insertions(+), 1 deletion(-)
 create mode 100755 t/t9148-git-svn-propset.sh

-- 
2.1.2

```

## Eric Sunshine, 2014-12-07 09:25

Subject: Re: [PATCH] git-svn: propset support v2
Message-ID: <CAPig+cQaP8KUFjFUqvxPZV1KiJePe_KisU4HSfZ1qVATOMriGw@mail.gmail.com>
URL: https://gitlist.dev/e/CAPig%2BcQaP8KUFjFUqvxPZV1KiJePe_KisU4HSfZ1qVATOMriGw%40mail.gmail.com
In-Reply-To: <20141206222918.GA91825@elvis.mu.org>

```
On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
> I have incorporated Eric Wong's feedback into the git-svn propset support patch.
>
> There is a nit that I want to point out.  The code does not support adding props
> unless there are also content changes to the files as well.  You can see this in
> the testcase.

This is an important nugget of information which would be worthwhile
to mention in the commit message of the patch rather than here as mere
commentary.

> That is still sufficient for many people's workflows (FreeBSD at
> least).  So I am wondering if this is OK.
>
> I would gladly take any pointers to making it work with unchanged
> files either for a later diff or to wrap this up.

```