Re: [PATCH] git-svn: propset support v2
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Dec 7, 2014, 09:25 UTC
- Message-ID
- <CAPig+cQaP8KUFjFUqvxPZV1KiJePe_KisU4HSfZ1qVATOMriGw@mail.gmail.com>
- In-Reply-To
- <20141206222918.GA91825@elvis.mu.org>
On Sat, Dec 6, 2014 at 5:29 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
Show 5 quoted lines
> I have incorporated Eric Wong's feedback into the git-svn propset support patch. > > There is a nit that I want to point out. The code does not support adding props > unless there are also content changes to the files as well. You can see this in > the testcase.
This is an important nugget of information which would be worthwhile to mention in the commit message of the patch rather than here as mere commentary.
Show 5 quoted lines
> That is still sufficient for many people's workflows (FreeBSD at > least). So I am wondering if this is OK. > > I would gladly take any pointers to making it work with unchanged > files either for a later diff or to wrap this up.