threads / patch / 37895

patchsparse: suppress an "using sizeof on a function" warning

Subject: [PATCH] sparse: suppress an "using sizeof on a function" warning

## tl;dr

4 messages between Nov 7, 2014 and Nov 7, 2014. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Ramsay Jones· Nov 7, 2014, 13:50 UTC · lore

Commit d57da44b1 ("imap-send: use libcurl for implementation", 06-11-2014) updates the implementation of the imap-send command to make use of libcurl's high(er)-level API functions.

In doing so, this introduces a sparse warning about "using sizeof on a function". In order to suppress the warning, we use the same solution used in commit 9371322a6 ("sparse: suppress some "using sizeof on a function" warnings", 06-10-2013) which solved exactly this problem for the other commands using libcurl.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---

Hi Bernhard,

If you need to re-roll your 'br/imap-send-via-libcurl' branch, could you please squash this into your patch.

Thanks!

ATB, Ramsay Jones

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index 1ded274..0fc2790 100644
--- a/Makefile
+++ b/Makefile
@@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX
 gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \
 	-DGIT_LOCALE_PATH='"$(localedir_SQ)"'
 
-http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \
+http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp: SPARSE_FLAGS += \
 	-DCURL_DISABLE_TYPECHECK
 
 ifdef NO_EXPAT

-- 
2.1.0

ockham@raz.or.at· Nov 7, 2014, 20:01 UTC · re: Ramsay Jones · lore

Re: [PATCH] sparse: suppress an "using sizeof on a function" warning

Zitat von Ramsay Jones <ramsay@ramsay1.demon.co.uk>:

Show 19 quoted lines

> Commit d57da44b1 ("imap-send: use libcurl for implementation",
> 06-11-2014) updates the implementation of the imap-send command
> to make use of libcurl's high(er)-level API functions.
>
> In doing so, this introduces a sparse warning about "using sizeof
> on a function". In order to suppress the warning, we use the same
> solution used in commit 9371322a6 ("sparse: suppress some "using
> sizeof on a function" warnings", 06-10-2013) which solved exactly
> this problem for the other commands using libcurl.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
>
> Hi Bernhard,
>
> If you need to re-roll your 'br/imap-send-via-libcurl' branch, could
> you please squash this into your patch.
>
> Thanks!

Hi Ramsay,

and thanks for your fix! TBH, I didn't even notice that my patch had already been committed and instead posted a refined version earlier today [1] (which unfortunately didn't contain your fix, either).

Not sure how to proceed. Maybe Junio can enlighten?

Regards Bernhard

[1] http://www.mail-archive.com/git@vger.kernel.org/msg60576.html

Show 22 quoted lines

> ATB,
> Ramsay Jones
>
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 1ded274..0fc2790 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1930,7 +1930,7 @@ gettext.sp gettext.s gettext.o: GIT-PREFIX
>  gettext.sp gettext.s gettext.o: EXTRA_CPPFLAGS = \
>  	-DGIT_LOCALE_PATH='"$(localedir_SQ)"'
>
> -http-push.sp http.sp http-walker.sp remote-curl.sp: SPARSE_FLAGS += \
> +http-push.sp http.sp http-walker.sp remote-curl.sp imap-send.sp:  
> SPARSE_FLAGS += \
>  	-DCURL_DISABLE_TYPECHECK
>
>  ifdef NO_EXPAT
> --
> 2.1.0

Junio C Hamano· Nov 7, 2014, 20:08 UTC · re: ockham@raz.or.at · lore

Re: [PATCH] sparse: suppress an "using sizeof on a function" warning

ockham@raz.or.at writes:

Show 7 quoted lines

> Hi Ramsay,
>
> and thanks for your fix! TBH, I didn't even notice that my patch had
> already been committed and instead posted a refined version earlier
> today [1] (which unfortunately didn't contain your fix, either).
>
> Not sure how to proceed. Maybe Junio can enlighten?

There is no "already committed" ;-)

Your patch is merely queued on 'pu' (proposed updates), which we all expect to be rerolled. You can just reroll another round, but you might want to wait a bit to see if there are more issues spotted by other people before doing so.

ockham@raz.or.at· Nov 7, 2014, 21:07 UTC · re: Junio C Hamano · lore

Re: [PATCH] sparse: suppress an "using sizeof on a function" warning

Zitat von Junio C Hamano <gitster@pobox.com>:

> Your patch is merely queued on 'pu' (proposed updates), which we all
> expect to be rerolled.  You can just reroll another round, but you
> might want to wait a bit to see if there are more issues spotted by
> other people before doing so.

Okay, I clearly need to acquaint myself some more with this project's review process.

One more question though I couldn't find answered in Documentation/SubmittingPatches: When squashing Ramsay's commit into mine, a) do I just keep the commit messages concatenated to each other, or b) do I reword his to fit in better with mine, and put the Signed-off-by lines at the very end? c) ?

Bernhard